From 013a8fd0b881e8a509f6f2fa080d672ad015686c Mon Sep 17 00:00:00 2001 From: Glease <4586901+Glease@users.noreply.github.com> Date: Fri, 10 Jan 2025 23:30:44 +0800 Subject: [PATCH] fix client world leak (#10) Co-authored-by: Martin Robertz --- .../amazingtrophies/model/ItemTrophyModelHandler.java | 8 ++++++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/src/main/java/glowredman/amazingtrophies/model/ItemTrophyModelHandler.java b/src/main/java/glowredman/amazingtrophies/model/ItemTrophyModelHandler.java index 3ef7d18..38f1709 100644 --- a/src/main/java/glowredman/amazingtrophies/model/ItemTrophyModelHandler.java +++ b/src/main/java/glowredman/amazingtrophies/model/ItemTrophyModelHandler.java @@ -88,8 +88,12 @@ public void render(double x, double y, double z, int rotation, @Nullable String OpenGlHelper.setActiveTexture(OpenGlHelper.defaultTexUnit); synchronized (this.item) { - this.item.setWorld(Minecraft.getMinecraft().theWorld); - RENDER.doRender(this.item, 0.0, 0.0, 0.0, 0.0f, 0.0f); + try { + this.item.setWorld(Minecraft.getMinecraft().theWorld); + RENDER.doRender(this.item, 0.0, 0.0, 0.0, 0.0f, 0.0f); + } finally { + this.item.setWorld(null); + } } GL11.glPopAttrib();