Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[1.16.2] Installing this mod with 'KubeJS-Fabric' causes custom recipes not to load properly. #34

Closed
Gbergz opened this issue Sep 3, 2020 · 10 comments
Labels
bug Something isn't working invalid This doesn't seem right

Comments

@Gbergz
Copy link

Gbergz commented Sep 3, 2020

Title^
Adding recipes through KubeJS with this mod installed makes the recipes added not work, but after a '/reload' it works like 25% of the time.
Also the recipes added gets added shown twice in REI. That is when a recipe added do work which it likely won't.
It's really hard to explain this but essentially when I load into a world and check for a custom recipe, it sometimes doesn't load. And if it loads (which is rare), it gets shown twice in REI. But then after a '/reload' or relog the recipe is gone again.

This doesn't happen when the mod is removed.
Meaning everything works as intended if this mod is removed.

Example of double REI recipes:
image

Versions:

Minecraft: 1.16.2
Fabric API: 0.19.0+build.398-1.16
IndRev: 1.6.2-BETA
KubeJS: 1.4.1

Other information:
This is reproducable for me on an empty instance with only Fabric API, Fabric Language Kotlin & KubeJS. And ofcourse Industrial Revolution. With a custom recipe.

- Gbergz

@GabrielOlvH GabrielOlvH added the bug Something isn't working label Sep 3, 2020
@GabrielOlvH
Copy link
Owner

Is there any log output that could be related to this?

@Gbergz
Copy link
Author

Gbergz commented Sep 3, 2020

I've been sitting trying to figure out what could be causing it for like 3 hours now. Logs say nothing. I've gotten help by AK9 and we're both unsure. Until I decided to remove a mod 1 by 1 until the problem went away. It did when I removed this mod.

@GabrielOlvH
Copy link
Owner

Can you please test if the issue is fixed with this version?

@Gbergz
Copy link
Author

Gbergz commented Sep 3, 2020

Just tried it, same issue persists unfortunately.

@Katorone
Copy link

Katorone commented Sep 3, 2020

In your log, are you seeing errors similar to these? KubeJS-Mods/KubeJS-Fabric#3
But pertaining to industrial revolution?

@Gbergz
Copy link
Author

Gbergz commented Sep 3, 2020

In your log, are you seeing errors similar to these? KubeJS-Mods/KubeJS-Fabric#3
But pertaining to industrial revolution?

Yes but only this line:
[ForkJoinPool.commonPool-worker-3/WARN]: Parsing error loading recipe techreborn:centrifuge/calciumcarbonate_cell net.minecraft.class_151: Non [a-z0-9_.-] character in namespace of location: {fluid:"techreborn:calcium_carbonate",holder:"techreborn:cell"}

Edit: Nothing similar in the logs like that line for Ind Rev.

@GabrielOlvH
Copy link
Owner

It's strange that it happens even without AE2 and TechReborn which is what I add compatibility recipes for. If you don't add any custom recipes does everything work as expected?

@Gbergz
Copy link
Author

Gbergz commented Sep 3, 2020

Recipes work like normal if there are no custom recipes available.

@GabrielOlvH
Copy link
Owner

I tried tracking this but could not find anything. This is possibly a KubeJS issue, I'd recommend opening an issue on their repository. If it ends up being an issue on my end, I'll happily fix it!

@GabrielOlvH GabrielOlvH added the invalid This doesn't seem right label Sep 4, 2020
@GabrielOlvH
Copy link
Owner

This should be fixed in the latest version of KubeJS, thanks for the report!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working invalid This doesn't seem right
Projects
None yet
Development

No branches or pull requests

3 participants