You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
An old token swap implementation was migrated from an internal codebase to the public sdk for broader consumption in pull request #468.
The scope of this issue is to take the migrated code, finish updating it to use more modern methods provided by the v2.x SDK, review it for potential security and refactoring improvements, and look for opportunities to share code with the recently drafted Token Sale feature (related issue: #443).
Open feedback left on the merged pull request #468 should be addressed in addition to the above higher level goals:
fix, resolve, or delete old todo comments
standardize use of UserAlias, await resolveUserAlias(), UserAlias in swap function params
error handling updates - this code was written long before ChainErrors were standardized and provided in the SDK and there are several places where errors can be handling differently
The text was updated successfully, but these errors were encountered:
An old token swap implementation was migrated from an internal codebase to the public sdk for broader consumption in pull request #468.
The scope of this issue is to take the migrated code, finish updating it to use more modern methods provided by the v2.x SDK, review it for potential security and refactoring improvements, and look for opportunities to share code with the recently drafted Token Sale feature (related issue: #443).
Open feedback left on the merged pull request #468 should be addressed in addition to the above higher level goals:
todo
commentsUserAlias
,await resolveUserAlias()
,UserAlias
in swap function paramsChainErrors
were standardized and provided in the SDK and there are several places where errors can be handling differentlyThe text was updated successfully, but these errors were encountered: