Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Review, Refactor, and Improve Token Swap implementation #470

Open
sentientforest opened this issue Dec 16, 2024 · 0 comments
Open

Review, Refactor, and Improve Token Swap implementation #470

sentientforest opened this issue Dec 16, 2024 · 0 comments

Comments

@sentientforest
Copy link
Contributor

An old token swap implementation was migrated from an internal codebase to the public sdk for broader consumption in pull request #468.

The scope of this issue is to take the migrated code, finish updating it to use more modern methods provided by the v2.x SDK, review it for potential security and refactoring improvements, and look for opportunities to share code with the recently drafted Token Sale feature (related issue: #443).

Open feedback left on the merged pull request #468 should be addressed in addition to the above higher level goals:

  • fix, resolve, or delete old todo comments
  • standardize use of UserAlias, await resolveUserAlias(), UserAlias in swap function params
  • error handling updates - this code was written long before ChainErrors were standardized and provided in the SDK and there are several places where errors can be handling differently
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant