Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a more recent Rust toolchain #78

Open
RyanGlScott opened this issue Feb 11, 2025 · 2 comments
Open

Use a more recent Rust toolchain #78

RyanGlScott opened this issue Feb 11, 2025 · 2 comments
Labels

Comments

@RyanGlScott
Copy link
Contributor

The Rust 2024 language edition is scheduled to be finalized real soon now as part of the 1.85.0 release of the Rust toolchain. We should update mir-json to target a nightly that includes Rust 2024 language edition support.

@spernsteiner has made some amount of progress towards this goal in this branch, but there is almost certainly more work that needs to be done.

@RyanGlScott RyanGlScott changed the title Use a toolchain that supports Rust 2024 Use a more recent Rust toolchain Feb 12, 2025
@RyanGlScott
Copy link
Contributor Author

I've retitled this to "a more recent Rust toolchain". I chose Rust 2024 as it is an arbitrary milestone in the future, but what is more important is having support for sufficiently new Rust code (for some definition of "sufficently new").

@spernsteiner
Copy link
Collaborator

Updating to the latest edition is a good idea anyway. Once the new edition is stable, cargo new will use it by default, and some existing projects will gradually migrate, making them difficult to build with mir-json even if they don't use any new APIs or language features. We've run into trouble with this in the past.

But I believe the 2024 edition is supported in the current nightlies, so any toolchain version we're likely to upgrade to will already support the edition.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants