-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Build crux-mir-comp by default #2060
Comments
Good catch. I think it would be worth adopting a position on what exactly the
|
My thought is that since it's the documented way to build the tree, it should build the whole tree. So I'll add the other executables. Re test components that could go either way. My instinct is that if you make a change with ramifications, and work through and fix everything so it all still builds again, and then the test code turns out not to compile, that this will at least be irritating and occasionally problematic (e.g. if you forget you need to get the tests built too and go on to the next breaking change) ... so I would vote for building all the test assets too. But if other people have other ideas I'm not super committed to that. |
(also, how do you do that?) |
If you want to build (but not run) a test suite component, you can run |
Writing down the results of a recent conversation with @sauclovian-g (and others) about the scope of the
The way that the #2061 achieves the goal stated in (1), persuant to the vision laid out in (2). More work is required to achieve the goal stated in (3), however. I don't think we need to do this as part of #2061, however, so I'm fine with landing #2061 as-is. We should open a separate issue to implement the remaining work needed for (3), which can be under the purview of the MTV remediation effort. |
Currently crux-mir-comp (and thus crucible-mir-comp) doesn't get built by build.sh, but only by the CI. This seems like a mistake; if nothing else it's annoying to have to do non-default builds to avoid CI failures when cleaning up or refactoring.
There's an extant issue (#1887) about running its test suite in the CI, which requires having mir-json installed. It doesn't appear necessary to have mir-json installed to just build it though.
The text was updated successfully, but these errors were encountered: