Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move button to activate embed feature from floating footer to menu #1328

Open
Miffael opened this issue May 25, 2018 · 1 comment
Open

Move button to activate embed feature from floating footer to menu #1328

Miffael opened this issue May 25, 2018 · 1 comment

Comments

@Miffael
Copy link
Collaborator

Miffael commented May 25, 2018

Move button to activate embed feature from floating footer to the menu.
Remove the button that triggers the embed feature from the floating footer and adds it to the main menu.
In the menu, it should be called 'Create a Comparison'.

@AntonOlkhovskyi
Copy link
Collaborator

Hi @Miffael ,
I have three remarks according to the task:

  1. When you click on CREATE COMPARISON it is became highlighted with green color. Can we remove it?
  2. Is it was renamed from Create a Comparison to CREATE COMPARISON? Please confirm if so.
  3. It looks really weird to have this menu item after social networks icons. As for me, this menu item should be added after Map and before social networks icons.
    And also we need to add translation key, for this item, to have it on the crowdin, at the moment we develop it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants