Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Handle missing concept errors from WS nicely #210

Open
angiehjort opened this issue Apr 20, 2021 · 2 comments
Open

Handle missing concept errors from WS nicely #210

angiehjort opened this issue Apr 20, 2021 · 2 comments

Comments

@angiehjort
Copy link
Member

Problem 1
Load bubble chart
Switch Y to male salaried workers (male_salaried_workers_percent_of_non_agricultural_male_employment)
Observe a crash due to a missing concept

http://www.localhost:4200/tools/#$model$markers$bubble$encoding$y$data$concept=male_salaried_workers_percent_of_non_agricultural_male_employment&space@=country&=time;;&scale$domain:null&zoomed:null;;;;;;&chart-type=bubbles&url=v1

Would be nice to get it reported back to us automatically via GA or Rollbar

Problem 2
need to rename male_salaried_workers_percent_of_non_agricultural_male_employment and add a redirect of concept because of Gapminder/big-waffle#49

@angiehjort angiehjort added this to the 2021-04-26 milestone Apr 20, 2021
@angiehjort angiehjort changed the title Handle missing concept nicely Handle missing concept errors from WS nicely Apr 20, 2021
@angiehjort angiehjort removed this from the 2021-04-26 milestone Apr 26, 2021
@angiehjort
Copy link
Member Author

cases to test

  • missing concept
  • missing CSV file
  • bad CSV file format (delimiter, columns, etc..)
  • network is down (at different points in loading)
  • asset is missing (world-50m.json)
  • more...?

@jheeffer
Copy link
Member

jheeffer commented Jun 21, 2021

You cannot get a non-CORS error in tools page for this WS response. However, you can update DDFServiceReader to throw on a concept > 64 characters until either the concept-id-length or the CORS-without-access-origin issue is fixed. Or indeed just change the concept id to <= 64 chars.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants