Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug when editing a collection percentage in the impact ranking and its projects in the overall ranking #96

Open
mmahdigh opened this issue Oct 23, 2023 · 1 comment

Comments

@mmahdigh
Copy link
Collaborator

How to reproduce:

1- Edit the percentages of some projects in a collection on the overall ranking page and save
2- Edit the share of the collection in the impact ranking (poll/root/ranking)
3- Check the invalid state in the overall ranking page

@mmahdigh mmahdigh self-assigned this Oct 23, 2023
@krisjpi
Copy link

krisjpi commented Nov 8, 2023

Ran into this a few times in testing, in several locations. Can edit correctly in very specific areas, but not all allocations.

notes:

  • In initial ranking changes, I can't seem to make a change and get a valid value. Anytime a number is manually adjusted, I get the "invalid value!" error instead of the "save" button.
  • Editing on the rankings page for anything above individual project allocations gives an "invalid value!" error. Changing project allocations correctly calculates the allocation changes for the rest of the group.
  • (at the project level) Locking projects also allows the correct calculations to be saved, and saving works properly with changed allocations remaining after the save from the Rankings page"

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants