-
-
Notifications
You must be signed in to change notification settings - Fork 11k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
v3.1 requires additional client adaptation, not just server version update #5733
Comments
It should not. The client always sends coordinates relative to the video size, and the mapping is done by the server. What has changed is that injecting control events properly requires a display for coordinates mapping. See #5611. |
Thanks for your response. I want to make sure I understand correctly:
I'm looking at #5611 but would appreciate if you could point out the specific changes needed for client implementation. |
✔️
Nothing. Just now you cannot use scrcpy-server only to send events without capturing a video stream (i.e. with In other words, if your client does the same as scrcpy (receive a video stream, listen to events in the local window and inject them), there is nothing to change in the client. |
Thank you for your help! Now I understand the issue. In my implementation, I was running three separate scrcpy server instances:
The issue was that I disabled video stream in the control server instance ( I'll modify my implementation to ensure the control server has video stream enabled. Thanks for pointing this out! |
Issue: v3.1 requires additional client adaptation, not just server version update
Description
I'm developing a Python client. In previous version updates (from v2.7 to v3.0.2), I only needed to update the server version and version number to maintain functionality. However, in v3.1, due to the change in Inject main display events to the original display, just updating the server is no longer sufficient.
Current Situation
deviceSize
instead ofinputSize
Questions
Looking forward to some guidance on how to properly adapt to this change.
The text was updated successfully, but these errors were encountered: