Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature Request]: Do not use a link for internally switching from automatic to manual auth #1307

Open
bigntallmike opened this issue Jan 23, 2025 · 1 comment
Labels

Comments

@bigntallmike
Copy link

Describe the bug

When registering a new account, after entering the server name, a browser is popped up. If it is the wrong browser, and the user wishes to copy and paste the blue-highlighted link into a different session, 'manual_auth' is what gets copied into the clipboard, instead of a valid URI to use for manual registration with a non-default browser session.

Steps To Reproduce

Open new account window
Enter a server url and hit Next
Close the opened browser
Right-click "try manual authorization" and "Copy Link Address"

Logs and/or Screenshots

No response

Instance Backend

Mastodon

Operating System

Fedora Linux 41 (Xfce)

Package

Flatpak

Troubleshooting information

No response

Additional Context

I run multiple browser instances for work, personal and experimentation and my default browser is never the one with my saved passwords for security reasons.

@bigntallmike bigntallmike added the bug Something isn't working label Jan 23, 2025
@GeopJr
Copy link
Owner

GeopJr commented Jan 24, 2025

If it is the wrong browser, and the user wishes to copy and paste the blue-highlighted link into a different session

Even if the 'Copy Link Address' action copied the manual link, it would be wrong for your use case. The link that opens when you are adding an account is the 'automatic' one, not the 'manual' one; so if you copied the 'manual' link, there wouldn't be an input to paste your access code manually. What you'd want to do would be to copy the link from the browser address bar that opened and paste it in the browser you want instead.

Which brings me to the second issue

'manual_auth' is what gets copied into the clipboard

That link is an internal one. It doesn't open in your browser, it acts as a button. If you click it, Tuba will open the 'manual' link in your browser and an entry will appear.

What I'm trying to get at is that even if I fixed this issue, it wouldn't make sense as copying the 'manual' link wouldn't make the entry to paste the access code your instance will display manually, so copying it would be meaningless. In that case, I'd say making it copy the manual link would be actually harmful as users would expect it to just work.


What I can do instead if move away from using a link for changing from 'automatic' to 'manual' and instead use a normal button; avoiding this whole confusion altogether.

        Didn't work?
============================
| Try manual authorization |
============================

(might need better wording)


I run multiple browser instances for work, personal and experimentation and my default browser is never the one with my saved passwords for security reasons.

You might find Junction useful! https://flathub.org/apps/re.sonny.Junction

@GeopJr GeopJr added enhancement New feature or request designer input needed and removed bug Something isn't working labels Jan 24, 2025
@GeopJr GeopJr changed the title [Bug]: Copy Link invalid on account registration [Feature Request]: Do not use a link for internally switching from automatic to manual auth Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants