Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Enhancement]Handle video property on VoIP push notification #641

Merged
merged 5 commits into from
Jan 27, 2025
Merged

[Enhancement]Handle video property on VoIP push notification #641

merged 5 commits into from
Jan 27, 2025
+127 −47

Conversation

ipavlidakis
Copy link
Collaborator

📝 Summary

By handling the video property on the VoIP push notification we can inform CallKit so the call will reported with correct suffix (video/audio)

☑️ Contributor Checklist

  • I have signed the Stream CLA (required)
  • This change follows zero ⚠️ policy (required)
  • This change should receive manual QA
  • Changelog is updated with client-facing changes
  • New code is covered by unit tests
  • Comparison screenshots added for visual changes
  • Affected documentation updated (tutorial, CMS)

@ipavlidakis ipavlidakis added the enhancement New feature or request label Jan 24, 2025
@ipavlidakis ipavlidakis self-assigned this Jan 24, 2025
@ipavlidakis ipavlidakis requested a review from a team as a code owner January 24, 2025 11:26
@Stream-SDK-Bot
Copy link
Collaborator

Stream-SDK-Bot commented Jan 24, 2025 •
edited
Loading

SDK Size

title develop branch diff status
StreamVideo 7.38 MB 7.38 MB 0 KB 🟢
StreamVideoSwiftUI 2.07 MB 2.07 MB +1 KB 🟢
StreamVideoUIKit 2.21 MB 2.21 MB 0 KB 🟢
StreamWebRTC 9.85 MB 9.85 MB 0 KB 🟢

@ipavlidakis ipavlidakis force-pushed the enhancement/handle-has-video-property-on-callkit-push-notification branch from 6449132 to d50bc4e Compare January 24, 2025 13:30
@ipavlidakis ipavlidakis enabled auto-merge (squash) January 24, 2025 15:38
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
147 New issues
0 Accepted issues

Measures
0 Security Hotspots
75.5% Coverage on New Code
0.5% Duplication on New Code

See analysis details on SonarQube Cloud

@ipavlidakis ipavlidakis merged commit 808ed28 into develop Jan 27, 2025
14 checks passed
@ipavlidakis ipavlidakis deleted the enhancement/handle-has-video-property-on-callkit-push-notification branch January 27, 2025 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@martinmitrevski martinmitrevski martinmitrevski approved these changes

Assignees

@ipavlidakis ipavlidakis

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ipavlidakis @Stream-SDK-Bot @martinmitrevski