Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use peerDependencies #7

Open
Soreine opened this issue Feb 5, 2018 · 2 comments
Open

Don't use peerDependencies #7

Soreine opened this issue Feb 5, 2018 · 2 comments

Comments

@Soreine
Copy link
Contributor

Soreine commented Feb 5, 2018

As pointed out here GitbookIO/slate-edit-table#59 (comment)

It would be simpler to have these as dependencies:

"eslint-plugin-flowtype": "^2.41.0",
"eslint-plugin-jsx-a11y": "^5.1.1",
"eslint-plugin-prettier": "^2.4.0",
"eslint-plugin-react": "^7.5.1",
"prettier": "^1.9.2", 
@zhouzi
Copy link
Contributor

zhouzi commented Mar 24, 2018

I was about to submit a PR but noticed the dependencies have been recently moved out of "dependencies" to "peerDependencies" by @SamyPesse in 477692b

@SamyPesse should they remain as peer dependencies?

Also, the package.json currently has two peerDependencies entries.

@SamyPesse
Copy link
Member

If I recall correctly, it's not working well with ESlint to have those as dependencies of the config. ESlint wanted those module as first-level dependencies.

It may has changed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants