-
-
Notifications
You must be signed in to change notification settings - Fork 40
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Correctly setup CORS for the webui #48
Comments
Does this issue still need work? I would be willing to try this out if needed. |
Yea, this is still needed (you can't load profiles in the UIs Dev mode when bind address is set), so I'd appreciate any help :) |
Sounds good, if you have any ideas on where to start looking for this too I would appreciate that. Feel free to assign this to me for now |
You'll need to start in |
Thanks for the tips, I will start reading up the codebase, also wondering if there were any particular guidelines on branches/branch names or anything I should keep in mind before I start writing anything? |
Nothing overt at the moment, the main key is that you'll want to make sure you're working off the latest Dev branch (dev-1.0.0 currently) and send your PR into that branch, once 1.0 is released I may tighten that up a bit, but for now it's sufficient. |
The WebUI currently misconfigures CORS if
--http-enable-cors
is enabled, as it will only accept 'external' requests from localhost.Look into providing a cleaner method of allowing users to define acceptable hosts (defaulting to localhost if none are defined).
The text was updated successfully, but these errors were encountered: