Bad error message and script for gogh.sh

[alexwolf22]

I had a lot of trouble using Gogh for Mac OS using iterm2. I kept getting the error message below. I think it should be more descriptive to help people use Gogh properly.

Unsupported terminal!

Supported terminals:
   mintty and deriviates
   guake
   iTerm2
   elementary terminal (pantheon/elementary)
   mate-terminal
   gnome-terminal
   tilix
   xfce4-terminal

If you believe you have recieved this message in error,
try manually setting `TERMINAL', hint: ps -h -o comm -p $PPID

I tried setting the TERMINAL env value to iTerm2 and other variants and it still would show that message each time I tried rerunning the script.

Similarly I tried running ps -h -o comm -p $PPID and kept getting the output COMM\nlogin which was related at all to the terminal type.

I eventually had to go trough through the script and see that the the $TERM_PROGRAM env is used to set the tone $TERMINAL. The value of this on my machine was 'iTerm.app' and when I set the TERMINAL env to that value it finally worked.

The error message should list add iTerm.app as a supported terminal option instead of the iTerm2 and it should also tell people to trying check the value of $TERM_PROGRAM.

Even better the gogh.sh should be able to detect the terminal type with my machine and setup.

[Mgldvd]

I’m closing this issue because it has been inactive for a few months. This probably means that it is not reproducible or it has been fixed in a newer version. If it’s an enhancement and hasn’t been taken on for so long, then it seems no one has the time to implement this.
Please reopen if you still encounter this issue with the latest version.
Thank you!

[vmdumitrache]

I would consider reopening this issue, if possible.
I can't seem to get it working on macOS Big Sur 11.6, and I am getting the same error as in the report above.
TERMINAL is unset and TERM_PROGRAM returns AppleTerminal.

Unlike in the above report, setting TERM_PROGRAM to iTerm.app just throws a new error:

No application knows how to open URL file:///Users/<obfuscated>/Monokai%20Dark.itermcolors (Error Domain=NSOSStatusErrorDomain Code=-10814 "kLSApplicationNotFoundErr: E.g. no application claims the file" UserInfo={_LSLine=1479, _LSFunction=runEvaluator}).

Thanks!

[Flopet]

I also have the same problem as @vmdumitrache
@Mgldvd Please reopen.

[denniskb]

Same problem on Mac OS 12.2 default terminal. No matter what I try (creating a "Default" profile, exporint TERMINAL, ...) I get "no application knows how to open ...itermcolors.

[phenonymous]

Same problem on Mac OS 12.2 default terminal.

Default terminal is using xterm-256color which does support colors however it is not supported by Gogh.
@denniskb can you create a separate issue for xterm-256color support.

---

@alexwolf22 I am unable replicate this issue. What version of macOS and iTerm2 (echo $TERM_PROGRAM_VERSION) are you using? What does env output for TERM, LC_TERMINAL and COLORTERM?

@vmdumitrache TERM_PROGRAM is the application itself it's not the terminal per se. Could you provide the values of above variables?

[stablestud]

For the original issue OP:
the error message has been updated in #442 to include the iTerm.app string for use with TERMINAL=iTerm.app

To the others:
Do your issues are still happening with the latest version of Gogh and with TERMINAL=iTerm.app?

[denniskb]

TERMINAL=iTerm.app working on Mac OS Sonoma and iTerm2.