From 3aa41ea28038858e16a25518ec7f615212f150ef Mon Sep 17 00:00:00 2001
From: Brendan Kenny <bckenny@gmail.com>
Date: Thu, 23 May 2024 14:55:31 -0500
Subject: [PATCH] INP attribution: allow for LoAFs observed before interaction
 events

---
 src/attribution/onINP.ts | 26 ++++++++++++++++++++++++--
 1 file changed, 24 insertions(+), 2 deletions(-)

diff --git a/src/attribution/onINP.ts b/src/attribution/onINP.ts
index 361fa4f2..4838e782 100644
--- a/src/attribution/onINP.ts
+++ b/src/attribution/onINP.ts
@@ -38,6 +38,12 @@ interface pendingEntriesGroup {
   entries: PerformanceEventTiming[];
 }
 
+/**
+ * The maximum number of LoAFs to retain on cleanup that don't have any
+ * overlapping events.
+ */
+const MAX_UNPAIRED_LOAFS = 20;
+
 // A PerformanceObserver, observing new `long-animation-frame` entries.
 // If this variable is defined it means the browser supports LoAF.
 let loafObserver: PerformanceObserver | undefined;
@@ -181,8 +187,10 @@ const cleanupEntries = () => {
     if (!renderTimesToKeep.has(key)) pendingEntriesGroupMap.delete(key);
   });
 
-  // Remove all pending LoAF entries that don't intersect with entries in
-  // the newly cleaned up `pendingEntriesGroupMap`.
+  // Keep all pending LoAF entries that
+  // - intersect with entries in the newly cleaned up `pendingEntriesGroupMap`
+  // - occur after all existing pendingEntriesGroups, in case a LoAF came in
+  //   before concurrent entries.
   const loafsToKeep: Set<PerformanceLongAnimationFrameTiming> = new Set();
   pendingEntriesGroupMap.forEach((group) => {
     getIntersectingLoAFs(group.startTime, group.processingEnd).forEach(
@@ -191,6 +199,20 @@ const cleanupEntries = () => {
       },
     );
   });
+  const latestRenderTime = Math.max.apply(Math, previousRenderTimes);
+  // Start at the end to keep the most recent `MAX_UNPAIRED_LOAFS` LoAFs.
+  const stoppingPoint = Math.max(
+    0,
+    pendingLoAFs.length - 1 - MAX_UNPAIRED_LOAFS,
+  );
+  for (let i = pendingLoAFs.length - 1; i >= stoppingPoint; i--) {
+    const loaf = pendingLoAFs[i];
+    // If reached LoAFs that overlap with events, no more will be after.
+    if (loafsToKeep.has(loaf) || loaf.startTime <= latestRenderTime) break;
+
+    loafsToKeep.add(loaf);
+  }
+
   pendingLoAFs = Array.from(loafsToKeep);
 
   // Reset the idle callback handle so it can be queued again.