Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why are only same-origin link elements supported? #90

Open
jmlee2k opened this issue Jan 29, 2025 · 0 comments
Open

Why are only same-origin link elements supported? #90

jmlee2k opened this issue Jan 29, 2025 · 0 comments

Comments

@jmlee2k
Copy link

jmlee2k commented Jan 29, 2025

Hello,

Thank you for this incredible polyfill!

As the title says, I'm just wondering why only same-origin link elements are supported?

For various reasons, we need to load some of our css from a different origin - I've removed the origin check here:

https://github.com/GoogleChromeLabs/container-query-polyfill/blob/main/src/engine.ts#L596

and it seems to work without issue, so I'm wondering if there is another reason for limiting it to same-origin links.

If the concern is simply to limit the scope, I'd be happy to make a PR allowing you to pass a function to whitelist origins or similar.

I'm aware that this is in maintenance mode, but I thought I'd ask anyways!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant