Spanner MR CMEK Integration

[panerorenn9541]

Promote Spanner MR CMEK support to GA:

Adds the new field kmsKeyNames to encryptionConfig to support creating a Spanner MR CMEK database.

Release Note Template for Downstream PRs (will be copied)

spanner: added `kmsKeyNames` to encryptionConfig of Database

[rahul2393]

LGTM

[github-actions]

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@c2thorn, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 30
Passed tests: 18
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages

• spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[modular-magician]

Tests analytics

Total tests: 30
Passed tests: 18
Skipped tests: 12
Affected tests: 0

Click here to see the affected service packages

• spanner

#### Non-exercised tests

Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek
  $\textcolor{green}{\textsf{All tests passed!}}$

View the build log

[c2thorn]

can you update the release note based on https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

I'll run the test in our environment to make sure its passing

[panerorenn9541]

can you update the release note based on https://googlecloudplatform.github.io/magic-modules/contribute/release-notes/

I'll run the test in our environment to make sure its passing

Added a note.

[c2thorn]

=== RUN   TestAccSpannerDatabase_mrcmek
=== PAUSE TestAccSpannerDatabase_mrcmek
=== CONT  TestAccSpannerDatabase_mrcmek
    vcr_utils.go:152: Step 1/2 error: Error running apply: exit status 1
        Error: Error creating Database: googleapi: Error 400: Invalid CreateDatabase request.
        Details:
        [
          {
            "@type": "type.googleapis.com/google.rpc.BadRequest",
            "fieldViolations": [
              {
                "description": "Expected projects/{project ID}/locations/{location ID}/keyRings/{keyring ID}/cryptoKeys/{kms_key_name}\nGot: google_kms_crypto_key.example-key-us-central1.id\nError: Resource name 'google_kms_crypto_key.example-key-us-central1.id' does not match pattern 'projects/([^/]{1,100})/locations/([a-zA-Z0-9_-]{1,63})/keyRings/([a-zA-Z0-9_-]{1,63})/cryptoKeys/([a-zA-Z0-9_-]{1,63})'.",
                "field": "encryption_config.kms_key_names[0]"
              }
            ]
          }
        ]
          with google_spanner_database.database,
          on terraform_plugin_test.tf line 9, in resource "google_spanner_database" "database":
           9: resource "google_spanner_database" "database" {

[panerorenn9541]

I am seeing the error "The Cloud Spanner multi-region CMEK feature is currently not supported"

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 38 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 3 files changed, 173 insertions(+), 2 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 165 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4159
Passed tests: 3736
Skipped tests: 418
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupVault_fullUpdate
• TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
• TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataformRepository_updated

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 153 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 3 files changed, 83 insertions(+), 2 deletions(-))
google-beta provider: Diff ( 4 files changed, 153 insertions(+), 3 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 11 insertions(+))

[modular-magician]

Tests analytics

Total tests: 4161
Passed tests: 3736
Skipped tests: 418
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupVault_fullUpdate
• TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
• TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataformRepository_updated
• TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample
• TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample

Get to know how VCR tests work

[modular-magician]

Tests analytics

Total tests: 4161
Passed tests: 3736
Skipped tests: 418
Affected tests: 7

Click here to see the affected service packages

All service packages are affected

#### Non-exercised tests

🔴 Tests were added that are skipped in VCR:

• TestAccSpannerDatabase_mrcmek

Action taken

Found 7 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

• TestAccBackupDRBackupVault_fullUpdate
• TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
• TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
• TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
• TestAccDataformRepository_updated
• TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample
• TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample

Get to know how VCR tests work

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Debug log]
TestAccDataformRepository_updated[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🔴 Tests failed during RECORDING mode:
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample[Error message] [Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

[modular-magician]

🟢 Tests passed during RECORDING mode:
TestAccBackupDRBackupVault_fullUpdate[Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Debug log]
TestAccDataformRepository_updated[Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureBasicExample[Debug log]
TestAccOracleDatabaseCloudExadataInfrastructure_oracledatabaseCloudExadataInfrastructureFullExample[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

---

🟢 All tests passed!

View the build log or the debug log for each test

done