Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add producer VPC spokes support to google_network_connectivity_spoke #11941

Closed
wants to merge 2 commits into from
Closed

Add producer VPC spokes support to google_network_connectivity_spoke #11941

wants to merge 2 commits into from

Conversation

juliocc
Copy link
Contributor

@juliocc juliocc commented Oct 8, 2024

Add support for producer VPC spokes to the NCC spoke resource

Release Note Template for Downstream PRs (will be copied)

networkconnectivity: added `linked_vpc_producer_network` field to `google_network_connectivity_spoke`

@github-actions GitHub Actions
Copy link

github-actions bot commented Oct 8, 2024

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@github-actions github-actions bot requested a review from ScottSuarez October 8, 2024 14:36
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 1 file changed, 24 insertions(+))
google-beta provider: Diff ( 9 files changed, 185 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 74 insertions(+), 12 deletions(-))

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_network_connectivity_spoke (14 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_network_connectivity_spoke" "primary" {
  linked_producer_vpc_network {
    exclude_export_ranges = # value needed
    include_export_ranges = # value needed
    network               = # value needed
    peering               = # value needed
  }
}

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4145
Passed tests: 3674
Skipped tests: 416
Affected tests: 55

Click here to see the affected service packages

All service packages are affected

Action taken

Found 55 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy
  • TestAccComputeRouterBgpPeer_routerPeerRouterAppliance
  • TestAccComputeRouterNat_AutoNetworkTier
  • TestAccComputeRouterNat_withPrivateNatAndEmptyAction
  • TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges
  • TestAccComputeRouterNat_withPrivateNatAndRules
  • TestAccComputeRouterPeer_routerApplianceInstance
  • TestAccComputeSubnetwork_subnetworkReservedInternalRangeExample
  • TestAccComputeSubnetwork_subnetworkReservedSecondaryRangeExample
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccMemorystoreInstance_memorystoreInstanceBasicExample
  • TestAccMemorystoreInstance_memorystoreInstanceFullExample
  • TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample
  • TestAccMemorystoreInstance_updateDeletionProtection
  • TestAccMemorystoreInstance_updatePersistence
  • TestAccMemorystoreInstance_updateRedisConfigs
  • TestAccMemorystoreInstance_updateReplicaCount
  • TestAccMemorystoreInstance_updateShardCount
  • TestAccNetworkConnectivityHub_BasicHub
  • TestAccNetworkConnectivityHub_BasicHubLongForm
  • TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample
  • TestAccNetworkConnectivityHub_networkConnectivityHubWithExportPscExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample_update
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample_update
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesMigrationExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesReserveWithOverlapExample
  • TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteBasicExample
  • TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteFullExample
  • TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointGlobalAccessExample
  • TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointRegionalAccessExample
  • TestAccNetworkConnectivityServiceConnectionPolicy_networkConnectivityPolicyBasicExample
  • TestAccNetworkConnectivityServiceConnectionPolicy_update
  • TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten
  • TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten
  • TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeInterconnectAttachmentBasicExample
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample
  • TestAccNetworkServicesGateway_swpAsNextHop
  • TestAccRedisCluster_createClusterWithNodeType
  • TestAccRedisCluster_createClusterWithZoneDistribution
  • TestAccRedisCluster_createUpdateDeletionProtection
  • TestAccRedisCluster_redisClusterHaExample
  • TestAccRedisCluster_redisClusterHaSingleZoneExample
  • TestAccRedisCluster_updateRedisConfigs
  • TestAccRedisCluster_updateReplicaCount
  • TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy[Debug log]
TestAccComputeRouterBgpPeer_routerPeerRouterAppliance[Debug log]
TestAccComputeRouterNat_AutoNetworkTier[Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyAction[Debug log]
TestAccComputeRouterNat_withPrivateNatAndEmptyActionActiveRanges[Debug log]
TestAccComputeRouterNat_withPrivateNatAndRules[Debug log]
TestAccComputeRouterPeer_routerApplianceInstance[Debug log]
TestAccNetworkConnectivityHub_BasicHub[Debug log]
TestAccNetworkConnectivityHub_BasicHubLongForm[Debug log]
TestAccNetworkConnectivityHub_networkConnectivityHubBasicExample[Debug log]
TestAccNetworkConnectivityHub_networkConnectivityHubWithExportPscExample[Debug log]
TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteBasicExample[Debug log]
TestAccNetworkConnectivityPolicyBasedRoute_networkConnectivityPolicyBasedRouteFullExample[Debug log]
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointGlobalAccessExample[Debug log]
TestAccNetworkConnectivityRegionalEndpoint_networkConnectivityRegionalEndpointRegionalAccessExample[Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWritten[Debug log]
TestAccNetworkConnectivitySpoke_LinkedVPCNetworkHandWrittenLongForm[Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWritten[Debug log]
TestAccNetworkConnectivitySpoke_RouterApplianceHandWrittenLongForm[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeInterconnectAttachmentBasicExample[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedVpcNetworkBasicExample[Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeRouterApplianceBasicExample[Debug log]
TestAccNetworkServicesGateway_swpAsNextHop[Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.

🔴 Tests failed during RECORDING mode:
TestAccComputeSubnetwork_subnetworkReservedInternalRangeExample[Error message] [Debug log]
TestAccComputeSubnetwork_subnetworkReservedSecondaryRangeExample[Error message] [Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample[Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample[Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample[Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection[Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence[Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs[Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount[Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample_update[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample_update[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesMigrationExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesReserveWithOverlapExample[Error message] [Debug log]
TestAccNetworkConnectivityServiceConnectionPolicy_networkConnectivityPolicyBasicExample[Error message] [Debug log]
TestAccNetworkConnectivityServiceConnectionPolicy_update[Error message] [Debug log]
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_createClusterWithZoneDistribution[Error message] [Debug log]
TestAccRedisCluster_createUpdateDeletionProtection[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaSingleZoneExample[Error message] [Debug log]
TestAccRedisCluster_updateRedisConfigs[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@juliocc
Copy link
Contributor Author

juliocc commented Oct 8, 2024

Added an example but it's currently failing because of a bug in the API's read operation. See b/372254716

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 2 files changed, 182 insertions(+))
google-beta provider: Diff ( 10 files changed, 343 insertions(+), 17 deletions(-))
terraform-google-conversion: Diff ( 6 files changed, 74 insertions(+), 12 deletions(-))
Open in Cloud Shell: Diff ( 4 files changed, 160 insertions(+))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4146
Passed tests: 3697
Skipped tests: 416
Affected tests: 33

Click here to see the affected service packages

All service packages are affected

Action taken

Found 33 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccComputeSubnetwork_subnetworkReservedInternalRangeExample
  • TestAccComputeSubnetwork_subnetworkReservedSecondaryRangeExample
  • TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample
  • TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample
  • TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample
  • TestAccDataformRepository_updated
  • TestAccDataprocCluster_withAutoscalingPolicy
  • TestAccMemorystoreInstance_memorystoreInstanceBasicExample
  • TestAccMemorystoreInstance_memorystoreInstanceFullExample
  • TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample
  • TestAccMemorystoreInstance_updateDeletionProtection
  • TestAccMemorystoreInstance_updatePersistence
  • TestAccMemorystoreInstance_updateRedisConfigs
  • TestAccMemorystoreInstance_updateReplicaCount
  • TestAccMemorystoreInstance_updateShardCount
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample_update
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample_update
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesMigrationExample
  • TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesReserveWithOverlapExample
  • TestAccNetworkConnectivityServiceConnectionPolicy_networkConnectivityPolicyBasicExample
  • TestAccNetworkConnectivityServiceConnectionPolicy_update
  • TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedProducerVpcNetworkExample
  • TestAccRedisCluster_createClusterWithNodeType
  • TestAccRedisCluster_createClusterWithZoneDistribution
  • TestAccRedisCluster_createUpdateDeletionProtection
  • TestAccRedisCluster_redisClusterHaExample
  • TestAccRedisCluster_redisClusterHaSingleZoneExample
  • TestAccRedisCluster_updateRedisConfigs
  • TestAccRedisCluster_updateReplicaCount
  • TestAccRedisCluster_updateShardCount

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccComputeSubnetwork_subnetworkReservedInternalRangeExample[Error message] [Debug log]
TestAccComputeSubnetwork_subnetworkReservedSecondaryRangeExample[Error message] [Debug log]
TestAccDataformRepositoryReleaseConfig_dataformRepositoryReleaseConfigExample[Error message] [Debug log]
TestAccDataformRepositoryWorkflowConfig_dataformRepositoryWorkflowConfigExample[Error message] [Debug log]
TestAccDataformRepository_dataformRepositoryWithCloudsourceRepoAndSshExample[Error message] [Debug log]
TestAccDataformRepository_updated[Error message] [Debug log]
TestAccDataprocCluster_withAutoscalingPolicy[Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceBasicExample[Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstanceFullExample[Error message] [Debug log]
TestAccMemorystoreInstance_memorystoreInstancePersistenceAofExample[Error message] [Debug log]
TestAccMemorystoreInstance_updateDeletionProtection[Error message] [Debug log]
TestAccMemorystoreInstance_updatePersistence[Error message] [Debug log]
TestAccMemorystoreInstance_updateRedisConfigs[Error message] [Debug log]
TestAccMemorystoreInstance_updateReplicaCount[Error message] [Debug log]
TestAccMemorystoreInstance_updateShardCount[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesAutomaticReservationExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesBasicExample_update[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesExternalRangesExample_update[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesMigrationExample[Error message] [Debug log]
TestAccNetworkConnectivityInternalRange_networkConnectivityInternalRangesReserveWithOverlapExample[Error message] [Debug log]
TestAccNetworkConnectivityServiceConnectionPolicy_networkConnectivityPolicyBasicExample[Error message] [Debug log]
TestAccNetworkConnectivityServiceConnectionPolicy_update[Error message] [Debug log]
TestAccNetworkConnectivitySpoke_networkConnectivitySpokeLinkedProducerVpcNetworkExample[Error message] [Debug log]
TestAccRedisCluster_createClusterWithNodeType[Error message] [Debug log]
TestAccRedisCluster_createClusterWithZoneDistribution[Error message] [Debug log]
TestAccRedisCluster_createUpdateDeletionProtection[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaExample[Error message] [Debug log]
TestAccRedisCluster_redisClusterHaSingleZoneExample[Error message] [Debug log]
TestAccRedisCluster_updateRedisConfigs[Error message] [Debug log]
TestAccRedisCluster_updateReplicaCount[Error message] [Debug log]
TestAccRedisCluster_updateShardCount[Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@juliocc
Copy link
Contributor Author

juliocc commented Oct 9, 2024

closing this in favor of #11934

@juliocc juliocc closed this Oct 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ScottSuarez ScottSuarez Awaiting requested review from ScottSuarez

Assignees
No one assigned
Labels
service/terraform
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@juliocc @modular-magician