Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Detect missing docs for datasource #12043

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Detect missing docs for datasource #12043

wants to merge 1 commit into from

Conversation

iyabchen
Copy link
Contributor

hashicorp/terraform-provider-google#14743
Part 2 - Detect missing docs for data source

Release Note Template for Downstream PRs (will be copied)

@github-actions github-actions bot requested a review from roaks3 October 17, 2024 20:08
@github-actions GitHub Actions
Copy link

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@iyabchen iyabchen requested review from shuyama1 and removed request for roaks3 October 17, 2024 20:08
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

Errors

google provider:

  • Failed to build branch auto-pr-12043-old

@shuyama1
Copy link
Member

/gcbrun

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@github-actions GitHub Actions
Copy link

@shuyama1 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions GitHub Actions
Copy link

@GoogleCloudPlatform/terraform-team @shuyama1 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

shuyama1
shuyama1 reviewed Oct 24, 2024
View reviewed changes
Copy link
Member

@shuyama1 shuyama1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll wait for #11156 to get merge first to do a deeper review. The additional change added in this PR looks mostly good to me by a quick glance and based on our offline discussion.

@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 7, 2024

@iyabchen, this PR is waiting for action from you. If no action is taken, this PR will be closed in 28 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions GitHub Actions
Copy link

@iyabchen, this PR is waiting for action from you. If no action is taken, this PR will be closed in 14 days.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 3, 2024

@iyabchen, this PR is waiting for action from you. If no action is taken, this PR will be closed in 2 weekdays.

Please address any comments or change requests, or re-request review from a core reviewer if no action is required.

Image showing the re-request review button

This notification can be disabled with the disable-automatic-closure label.

@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

@iyabchen, this PR is being closed due to inactivity.

@github-actions github-actions bot closed this Dec 5, 2024
@shuyama1 shuyama1 reopened this Dec 5, 2024
@github-actions github-actions bot requested a review from shuyama1 December 5, 2024 16:00
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@github-actions GitHub Actions
Copy link

@roaks3 This PR has been waiting for review for 3 weekdays. Please take a look! Use the label disable-review-reminders to disable these notifications.

@github-actions GitHub Actions
Copy link

@GoogleCloudPlatform/terraform-team @roaks3 This PR has been waiting for review for 1 week. Please take a look! Use the label disable-review-reminders to disable these notifications.

@roaks3 roaks3 requested review from roaks3 and shuyama1 and removed request for shuyama1 and roaks3 December 12, 2024 16:15
@shuyama1
Copy link
Member

@iyabchen Part 1 is merged. Would you mind rebasing this PR when you have chance? Thank you!

@iyabchen iyabchen force-pushed the detect-missing-docs-datasource branch from 3df2265 to 5e965c4 Compare January 22, 2025 23:29
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@iyabchen iyabchen force-pushed the detect-missing-docs-datasource branch from 5e965c4 to 51db267 Compare January 22, 2025 23:55
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@iyabchen iyabchen force-pushed the detect-missing-docs-datasource branch from 51db267 to 77573b4 Compare January 23, 2025 01:08
@iyabchen iyabchen force-pushed the detect-missing-docs-datasource branch from 77573b4 to 8a60c11 Compare January 23, 2025 01:10
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

1 similar comment
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR hasn't generated any diffs, but I'll let you know if a future commit does.

@iyabchen
Copy link
Contributor Author

@shuyama1 I rebased, added the datasource detector, and clean up some not used variables. This should be ready to review.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shuyama1 shuyama1 Awaiting requested review from shuyama1

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
disable-automatic-closure disable-review-reminders
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iyabchen @modular-magician @shuyama1