Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for extra attributes oauth2 client #12721

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

omkark-google
Copy link
Contributor

@omkark-google omkark-google commented Jan 9, 2025

Add support for extra attributes oauth2 client fields to create workforce pool operation for SAML protocol. This address the gap between newly added support in Gcloud command of iam create workforce pool provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` resource

@github-actions github-actions bot requested a review from ScottSuarez January 9, 2025 19:29
Copy link

github-actions bot commented Jan 9, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@ScottSuarez, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician modular-magician added the awaiting-approval Pull requests that need reviewer's approval to run presubmit tests label Jan 9, 2025
@ScottSuarez
Copy link
Contributor

hashicorp/terraform-provider-google#20862

Omkark, could you register internally so CI can run without manual approval.
go/terraform-contribution-guide#before-you-begin

Also, the release note seems incorrect as no new field is being added. It seems only tests are being added for existing behavior.

@omkark-google omkark-google force-pushed the extra-attributes-saml-support branch 2 times, most recently from a8ae85a to 718f926 Compare January 11, 2025 18:25
@modular-magician modular-magician added service/iam-workforce and removed awaiting-approval Pull requests that need reviewer's approval to run presubmit tests labels Jan 11, 2025
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 263 insertions(+), 11 deletions(-))
google-beta provider: Diff ( 4 files changed, 263 insertions(+), 11 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 11
Skipped tests: 0
Affected tests: 4

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 4 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolOidcProvider_extraAttributesOauth2Client
  • TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample
  • TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample
  • TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolOidcProvider_extraAttributesOauth2Client [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

@omkark-google omkark-google force-pushed the extra-attributes-saml-support branch from 718f926 to c8eea85 Compare January 11, 2025 18:58
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 265 insertions(+), 13 deletions(-))
google-beta provider: Diff ( 4 files changed, 265 insertions(+), 13 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 12
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample
  • TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample
  • TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

fields to create workforce pool operation. This
address the gap between newly added support in
Gcloud command of iam create workforce pool
provider and iam update workforce pool provider.

Fixes hashicorp/terraform-provider-google#20862

```
iam: added `extra_attributes_oauth2_client` field to `google_iam_workforce_pool_provider` SAML resource
```
@omkark-google omkark-google force-pushed the extra-attributes-saml-support branch from c8eea85 to dae1ac4 Compare January 11, 2025 19:31
@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 4 files changed, 266 insertions(+), 14 deletions(-))
google-beta provider: Diff ( 4 files changed, 266 insertions(+), 14 deletions(-))

@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 15
Passed tests: 12
Skipped tests: 0
Affected tests: 3

Click here to see the affected service packages
  • iamworkforcepool

Action taken

Found 3 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample
  • TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample
  • TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderOidcFullExample [Debug log]

🟢 No issues found for passed tests after REPLAYING rerun.


🔴 Tests failed during RECORDING mode:
TestAccIAMWorkforcePoolWorkforcePoolProvider_iamWorkforcePoolProviderSamlFullExample [Error message] [Debug log]
TestAccIAMWorkforcePoolWorkforcePoolSamlProvider_extraAttributesOauth2Client [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add ExtraAttributesOauthClient field for google_iam_workforce_pool_provider resource
3 participants