-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Resource policy attachment #12812
base: main
Are you sure you want to change the base?
Resource policy attachment #12812
Conversation
Hello! I am a robot. Tests will require approval from a repository maintainer to run. @NickElliot, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look. You can help make sure that review is quick by doing a self-review and by running impacted tests locally. |
@NickElliot This PR has been waiting for review for 3 weekdays. Please take a look! Use the label |
@GoogleCloudPlatform/terraform-team @NickElliot This PR has been waiting for review for 1 week. Please take a look! Use the label |
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_resource_policy_attachment" "primary" {
instance = # value needed
name = # value needed
zone = # value needed
}
|
Tests analyticsTotal tests: 1097 Click here to see the affected service packages
🟢 All tests passed! View the build log |
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Co-authored-by: Nick Elliot <[email protected]>
Hi there, I'm the Modular magician. I've detected the following information about your changes: Diff reportYour PR generated some diffs in downstreams - here they are.
Missing test reportYour PR includes resource fields which are not covered by any test. Resource: resource "google_compute_resource_policy_attachment" "primary" {
instance = # value needed
name = # value needed
zone = # value needed
}
|
Tests analyticsTotal tests: 1100 Click here to see the affected service packages
🟢 All tests passed! View the build log |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can you add your example details to the ResourcePolicyAttachment yaml? see here: https://googlecloudplatform.github.io/magic-modules/test/test/
This PR adds a new resource
ResourcePolicyAttachment
.Related Issues
Release Note
See Write release notes for guidance.