Migrate google_eventarc_trigger resource from DCL to MMv1 #12832

tommyreddad · 2025-01-22T21:36:31Z

This PR is to move the Eventarc Trigger (google_eventarc_trigger) resource from DCL to MMv1. This PR includes:

Creation of the resource on MMv1.
Creation of the examples and tests.
Addition of extra tests for long-form and short-form fields.
Remove references to DCL resource.

Release Note Template for Downstream PRs (will be copied)

eventarc: `google_eventarc_trigger` now uses MMv1 engine instead of DCL.

github-actions · 2025-01-22T21:37:10Z

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@roaks3, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

modular-magician · 2025-01-22T21:47:51Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 1961 insertions(+), 1153 deletions(-))
google-beta provider: Diff ( 16 files changed, 1961 insertions(+), 1153 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 458 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_eventarc_trigger (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_eventarc_trigger" "primary" {
  event_data_content_type = # value needed
  matching_criteria {
    operator = # value needed
  }
}

modular-magician · 2025-01-22T21:51:34Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 1961 insertions(+), 1153 deletions(-))
google-beta provider: Diff ( 16 files changed, 1961 insertions(+), 1153 deletions(-))
terraform-google-conversion: Diff ( 1 file changed, 458 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_eventarc_trigger (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_eventarc_trigger" "primary" {
  event_data_content_type = # value needed
  matching_criteria {
    operator = # value needed
  }
}

modular-magician · 2025-01-22T22:19:16Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 1961 insertions(+), 1153 deletions(-))
google-beta provider: Diff ( 16 files changed, 1961 insertions(+), 1153 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 509 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

Missing test report

Your PR includes resource fields which are not covered by any test.

Resource: google_eventarc_trigger (8 total tests)
Please add an acceptance test which includes these fields. The test should include the following:

resource "google_eventarc_trigger" "primary" {
  event_data_content_type = # value needed
  matching_criteria {
    operator = # value needed
  }
}

modular-magician · 2025-01-22T23:01:43Z

Tests analytics

Total tests: 4494
Passed tests: 4057
Skipped tests: 427
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccEventarcTrigger_BasicHandWritten

TestAccEventarcTrigger_HttpDest

TestAccEventarcTrigger_alternateForm

TestAccEventarcTrigger_channel

TestAccEventarcTrigger_shortFormWorkflow

TestAccEventarcTrigger_workflow

TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

modular-magician · 2025-01-22T23:05:34Z

Tests analytics

Total tests: 4494
Passed tests: 4057
Skipped tests: 427
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccEventarcTrigger_BasicHandWritten

TestAccEventarcTrigger_HttpDest

TestAccEventarcTrigger_alternateForm

TestAccEventarcTrigger_channel

TestAccEventarcTrigger_shortFormWorkflow

TestAccEventarcTrigger_workflow

TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

modular-magician · 2025-01-22T23:16:39Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccEventarcTrigger_BasicHandWritten [Debug log]
TestAccEventarcTrigger_HttpDest [Debug log]
TestAccEventarcTrigger_alternateForm [Debug log]
TestAccEventarcTrigger_channel [Debug log]
TestAccEventarcTrigger_shortFormWorkflow [Debug log]
TestAccEventarcTrigger_workflow [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

tommyreddad · 2025-01-22T23:18:25Z

I'm going to add an acceptance test for the missing fields, and move some of the tests to be auto-generated when possible.

modular-magician · 2025-01-22T23:19:43Z

🟢 Tests passed during RECORDING mode:
TestAccEventarcTrigger_BasicHandWritten [Debug log]
TestAccEventarcTrigger_HttpDest [Debug log]
TestAccEventarcTrigger_alternateForm [Debug log]
TestAccEventarcTrigger_channel [Debug log]
TestAccEventarcTrigger_shortFormWorkflow [Debug log]
TestAccEventarcTrigger_workflow [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-22T23:33:49Z

Tests analytics

Total tests: 4494
Passed tests: 4057
Skipped tests: 427
Affected tests: 10

Click here to see the affected service packages

All service packages are affected

Action taken

Found 10 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccEventarcTrigger_BasicHandWritten

TestAccEventarcTrigger_HttpDest

TestAccEventarcTrigger_alternateForm

TestAccEventarcTrigger_channel

TestAccEventarcTrigger_shortFormWorkflow

TestAccEventarcTrigger_workflow

Get to know how VCR tests work

modular-magician · 2025-01-22T23:50:33Z

🟢 Tests passed during RECORDING mode:
TestAccComputeRegionPerInstanceConfig_removeInstanceOnDestroy [Debug log]
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccEventarcTrigger_BasicHandWritten [Debug log]
TestAccEventarcTrigger_HttpDest [Debug log]
TestAccEventarcTrigger_alternateForm [Debug log]
TestAccEventarcTrigger_channel [Debug log]
TestAccEventarcTrigger_shortFormWorkflow [Debug log]
TestAccEventarcTrigger_workflow [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-23T15:32:41Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2074 insertions(+), 1030 deletions(-))
google-beta provider: Diff ( 16 files changed, 2074 insertions(+), 1030 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 509 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 775 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-01-23T16:43:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2178 insertions(+), 1134 deletions(-))
google-beta provider: Diff ( 16 files changed, 2178 insertions(+), 1134 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 509 insertions(+))
Open in Cloud Shell: Diff ( 20 files changed, 775 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-01-23T16:49:40Z

Tests analytics

Total tests: 4498
Passed tests: 4058
Skipped tests: 428
Affected tests: 12

Click here to see the affected service packages

All service packages are affected

Action taken

Found 12 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccEventarcTrigger_AlternateForm

TestAccEventarcTrigger_BasicHandWritten

TestAccEventarcTrigger_ShortFormWorkflow

TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample

TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample

TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample

TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample

TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample

TestAccStorageTransferReplicationJob_basic

Get to know how VCR tests work

modular-magician · 2025-01-23T17:08:07Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccEventarcTrigger_AlternateForm [Debug log]
TestAccEventarcTrigger_BasicHandWritten [Debug log]
TestAccEventarcTrigger_ShortFormWorkflow [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]
TestAccStorageTransferReplicationJob_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-23T17:58:42Z

Tests analytics

Total tests: 4498
Passed tests: 4059
Skipped tests: 428
Affected tests: 11

Click here to see the affected service packages

All service packages are affected

Action taken

Found 11 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccEventarcTrigger_AlternateForm

TestAccEventarcTrigger_BasicHandWritten

TestAccEventarcTrigger_ShortFormWorkflow

TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample

TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample

TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample

TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample

TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample

Get to know how VCR tests work

modular-magician · 2025-01-23T18:16:24Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccEventarcTrigger_AlternateForm [Debug log]
TestAccEventarcTrigger_BasicHandWritten [Debug log]
TestAccEventarcTrigger_ShortFormWorkflow [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithCloudRunDestinationExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithHttpDestinationExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithPathPatternFilterExample [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithWorkflowDestinationExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

tommyreddad · 2025-01-23T19:16:24Z

I don't believe the failing tests are related to any changes in this PR.

modular-magician · 2025-01-23T20:41:02Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2173 insertions(+), 1134 deletions(-))
google-beta provider: Diff ( 16 files changed, 2173 insertions(+), 1134 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 509 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 605 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-01-23T21:08:26Z

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google provider: Diff ( 16 files changed, 2197 insertions(+), 1170 deletions(-))
google-beta provider: Diff ( 16 files changed, 2197 insertions(+), 1170 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 509 insertions(+))
Open in Cloud Shell: Diff ( 16 files changed, 605 insertions(+))

Breaking Change(s) Detected

The following breaking change(s) were detected within your pull request.

Field project lost its diff suppress function - reference

If you believe this detection to be incorrect please raise the concern with your reviewer.
If you intend to make this change you will need to wait for a major release window.
An override-breaking-change label can be added to allow merging.

modular-magician · 2025-01-23T21:57:21Z

Tests analytics

Total tests: 4499
Passed tests: 4066
Skipped tests: 428
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample

TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample

Get to know how VCR tests work

modular-magician · 2025-01-23T22:10:21Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

modular-magician · 2025-01-23T22:23:50Z

Tests analytics

Total tests: 4499
Passed tests: 4065
Skipped tests: 428
Affected tests: 6

Click here to see the affected service packages

All service packages are affected

Action taken

Found 6 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests

TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample

TestAccDataSourceGoogleGkeHubFeature_basic

TestAccEphemeralServiceAccountKey_basic

TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample

TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample

TestAccTpuV2Vm_update

Get to know how VCR tests work

modular-magician · 2025-01-23T22:46:29Z

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccEventarcTrigger_eventarcTriggerWithChannelCmekExample [Debug log]
TestAccTpuV2Vm_update [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.

🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccNetworkSecurityAuthzPolicy_networkServicesAuthzPolicyAdvancedExample [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

roaks3 · 2025-01-24T16:02:58Z

@trodge this looks like a DCL migration, so passing to you (assuming that's the correct thing to do here, as I know you and Sam have been close to this)

tommyreddad and others added 8 commits January 15, 2025 15:38

Initial commit for Trigger MMv1 migration

2c45cea

Remove Eventarc from provider_dcl_endpoints

b059b82

Migrate Trigger tests to MMv1

ecad37b

Add Trigger basic example

a532a68

Revert changes to provider_dcl_endpoints

7a34518

Add workflow test and expand/flatten for trigger

6321b22

Add more fields and alternate form handling

c2f92e5

Merge branch 'GoogleCloudPlatform:main' into trigger-migration

b51fbec

github-actions bot requested a review from roaks3 January 22, 2025 21:37

Fix product.yaml lint

95508ab

modular-magician added the service/eventarc label Jan 22, 2025

Add eventarc_utils to converter

fa2d21b

Improve generated test coverage

43c3b57

Format tf.tmpl files

bae7ecf

Bootstrap KMS key

cc63a42

Format test terraform config

b37c071

roaks3 requested a review from trodge January 24, 2025 16:01

roaks3 removed their request for review January 24, 2025 16:03

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Migrate google_eventarc_trigger resource from DCL to MMv1 #12832

Migrate google_eventarc_trigger resource from DCL to MMv1 #12832

tommyreddad commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

tommyreddad commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

tommyreddad commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

roaks3 commented Jan 24, 2025

Migrate google_eventarc_trigger resource from DCL to MMv1 #12832

Are you sure you want to change the base?

Migrate google_eventarc_trigger resource from DCL to MMv1 #12832

Conversation

tommyreddad commented Jan 22, 2025

github-actions bot commented Jan 22, 2025

modular-magician commented Jan 22, 2025

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Jan 22, 2025

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Jan 22, 2025

Diff report

Breaking Change(s) Detected

Missing test report

modular-magician commented Jan 22, 2025

Tests analytics

Action taken

modular-magician commented Jan 22, 2025

Tests analytics

Action taken

modular-magician commented Jan 22, 2025

tommyreddad commented Jan 22, 2025

modular-magician commented Jan 22, 2025

modular-magician commented Jan 22, 2025

Tests analytics

Action taken

modular-magician commented Jan 22, 2025

modular-magician commented Jan 23, 2025

Diff report

Breaking Change(s) Detected

modular-magician commented Jan 23, 2025

Diff report

Breaking Change(s) Detected

modular-magician commented Jan 23, 2025

Tests analytics

Action taken

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

Tests analytics

Action taken

modular-magician commented Jan 23, 2025

tommyreddad commented Jan 23, 2025

modular-magician commented Jan 23, 2025

Diff report

Breaking Change(s) Detected

modular-magician commented Jan 23, 2025

Diff report

Breaking Change(s) Detected

modular-magician commented Jan 23, 2025

Tests analytics

Action taken

modular-magician commented Jan 23, 2025

modular-magician commented Jan 23, 2025

Tests analytics

Action taken

modular-magician commented Jan 23, 2025

roaks3 commented Jan 24, 2025