Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use the v2alpha1 Cloud TPU API version in the google-beta Terraform provider #12844

Merged
merged 1 commit into from
Jan 23, 2025

Conversation

zeleena
Copy link
Contributor

@zeleena zeleena commented Jan 23, 2025

Use the v2alpha1 Cloud TPU API version in the google-beta Terraform provider. Left a comment with brief justification, and extended justification can be found in go/terraform-for-tpus.

tpuv2: used the v2alpha1 Cloud TPU API version in the google-beta provider.

@github-actions github-actions bot requested a review from BBBmau January 23, 2025 18:18
Copy link

github-actions bot commented Jan 23, 2025

Hello! I am a robot. Tests will require approval from a repository maintainer to run.

@melinath, a repository maintainer, has been assigned to review your changes. If you have not received review feedback within 2 business days, please leave a comment on this PR asking them to take a look.

You can help make sure that review is quick by doing a self-review and by running impacted tests locally.

@modular-magician
Copy link
Collaborator

Hi there, I'm the Modular magician. I've detected the following information about your changes:

Diff report

Your PR generated some diffs in downstreams - here they are.

google-beta provider: Diff ( 5 files changed, 7 insertions(+), 7 deletions(-))
terraform-google-conversion: Diff ( 2 files changed, 4 insertions(+), 4 deletions(-))

@melinath
Copy link
Member

@modular-magician reassign-reviewer melinath

@melinath melinath removed the request for review from BBBmau January 23, 2025 18:47
@github-actions github-actions bot requested a review from melinath January 23, 2025 18:48
@modular-magician
Copy link
Collaborator

Tests analytics

Total tests: 4494
Passed tests: 4061
Skipped tests: 428
Affected tests: 5

Click here to see the affected service packages

All service packages are affected

Action taken

Found 5 affected test(s) by replaying old test recordings. Starting RECORDING based on the most recent commit. Click here to see the affected tests
  • TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample
  • TestAccDataSourceGoogleGkeHubFeature_basic
  • TestAccEphemeralServiceAccountKey_basic
  • TestAccStorageTransferReplicationJob_basic
  • TestAccTpuV2Vm_update

Get to know how VCR tests work

@modular-magician
Copy link
Collaborator

🟢 Tests passed during RECORDING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Debug log]
TestAccStorageTransferReplicationJob_basic [Debug log]

🔴 Tests failed when rerunning REPLAYING mode:
TestAccDataSourceGoogleGkeHubFeature_basic [Error message] [Debug log]

Tests failed due to non-determinism or randomness when the VCR replayed the response after the HTTP request was made.

Please fix these to complete your PR. If you believe these test failures to be incorrect or unrelated to your change, or if you have any questions, please raise the concern with your reviewer.


🔴 Tests failed during RECORDING mode:
TestAccApigeeEnvironmentAddonsConfig_apigeeEnvAddonsAnalyticsTestExample [Error message] [Debug log]
TestAccEphemeralServiceAccountKey_basic [Error message] [Debug log]
TestAccTpuV2Vm_update [Error message] [Debug log]

🔴 Errors occurred during RECORDING mode. Please fix them to complete your PR.

View the build log or the debug log for each test

Copy link
Member

@melinath melinath left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Failures seem unrelated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants