-
Notifications
You must be signed in to change notification settings - Fork 62
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix flaky test #2263
Comments
@omarkasem, could you please provide a status update? |
- Implements #2263 - Adds full date to compare correctly 💾 [Build file](https://www.dropbox.com/scl/fi/7mkhxg11m6xs8o2c2p93h/gravityview-2.35-cff893771.zip?rlkey=9cm86gltegno7p1emaj81abdx&dl=1) (cff8937).
@omarkasem, tests are still failing: #2284 (comment) |
The problem is that the generated date for the entries sometimes is in the future, instead of the past; which the test assumed. So easy fix is to set test date fixed (which I did). Restored the time test as well. And added a data provider instead of a loop of assertions; so we know what iteration causes the test to fail. So hopefully it is now a thing of the past. |
Fixed in d6381d3. |
Fix flaky test
Failed asserting that two strings are equal.
--- Expected
+++ Actual
@@ @@
-'22 hours from now'
+'22 hours ago'
12e1131
The text was updated successfully, but these errors were encountered: