Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flaky test #2263

Closed
omarkasem opened this issue Jan 22, 2025 · 6 comments · Fixed by #2284
Closed

Fix flaky test #2263

omarkasem opened this issue Jan 22, 2025 · 6 comments · Fixed by #2284
Assignees

Comments

@omarkasem
Copy link
Collaborator

Fix flaky test

  1. GVCommon_Test::test_format_date
    Failed asserting that two strings are equal.
    --- Expected
    +++ Actual
    @@ @@
    -'22 hours from now'
    +'22 hours ago'

12e1131

@omarkasem omarkasem self-assigned this Jan 22, 2025
@mrcasual
Copy link
Collaborator

@omarkasem, could you please provide a status update?

@omarkasem omarkasem linked a pull request Feb 13, 2025 that will close this issue
mrcasual added a commit that referenced this issue Feb 16, 2025

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@mrcasual mrcasual reopened this Feb 16, 2025
@mrcasual
Copy link
Collaborator

mrcasual commented Feb 16, 2025

@omarkasem, tests are still failing: #2284 (comment)

@doekenorg
Copy link
Contributor

The problem is that the generated date for the entries sometimes is in the future, instead of the past; which the test assumed. So easy fix is to set test date fixed (which I did). Restored the time test as well. And added a data provider instead of a loop of assertions; so we know what iteration causes the test to fail. So hopefully it is now a thing of the past.

@mrcasual
Copy link
Collaborator

Fixed in d6381d3.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants