Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Can't add entry notes when running WP's 2022 theme or newer #2266

Open
mrcasual opened this issue Jan 29, 2025 · 0 comments
Open

Can't add entry notes when running WP's 2022 theme or newer #2266

mrcasual opened this issue Jan 29, 2025 · 0 comments
Assignees
@mrcasual
Labels
Bug

Comments

@mrcasual
Copy link
Collaborator

mrcasual commented Jan 29, 2025 •
edited
Loading

JS error: Uncaught ReferenceError: GVNotes is not defined

To reproduce:

  1. Configure the site to use the Twenty Twenty-Five theme.
  2. Add an Entry Notes field to the View.
  3. Open the View on the frontend and add a note.

Slack discussion.
@mrcasual mrcasual self-assigned this Jan 29, 2025
@mrcasual mrcasual added the Bug label Jan 29, 2025
mrcasual added a commit that referenced this issue Jan 29, 2025
@mrcasual
Simplify Entry Notes asset loading
97a16d0 
This fixes script registration occurring after localization,
affecting Twenty Twenty-Two and newer themes (#2266).
@mrcasual mrcasual mentioned this issue Jan 29, 2025
Merged
mrcasual added a commit that referenced this issue Jan 29, 2025
@mrcasual
Simplify Entry Notes asset loading
7c5c1aa 
This fixes script registration occurring after localization,
affecting Twenty Twenty-Two and newer themes (#2266).
mrcasual added a commit that referenced this issue Jan 29, 2025
@mrcasual
Simplify Entry Notes asset loading
1d5dcd3 
This fixes script registration occurring after localization,
affecting Twenty Twenty-Two and newer themes (#2266).
mrcasual added a commit that referenced this issue Jan 30, 2025
@mrcasual
Fix script localization issue with Entry Notes assets (#2267)
74a3b70 
This implements #2266.

💾 [Build
file](https://www.dropbox.com/scl/fi/9vtob5nto1ks9gnkr9ga6/gravityview-2.34-8dacc0fa2.zip?rlkey=69upf8c5m25xgxorsfn4k5bhr&dl=1)
(8dacc0f).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mrcasual mrcasual

Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@mrcasual