-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
POC: Use stream categories and permissions for aggregation event definitions #20188
POC: Use stream categories and permissions for aggregation event definitions #20188
Conversation
… use-stream-categories-for-aggregation-event-definitions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kingzacko1 This LGTM and tests successfully for both filter and aggregation events and with categories and standard streams. The approach looks good as far as I can see. I will do a little more testing with permissions on Monday morning.
I did not see any errors being logged about a missing header I think like you were mentioning. Are you still seeing those on your side?
@danotorrey did you create an event definition with a user other than |
@kingzacko1 I just tested with an event definition created by another user and still did not see the error. We can take a look after the high five if you have some time. |
…and-permissions-for-aggregations
I'm closing this for now. We will likely handle something like this in a more sweeping change to event definitions as a whole. |
Adds a pseudo-SearchUser class
EventProcessorSearchUser
to use when adding streams to event processor searches. The class is used to respect stream permissions of the event definition owner when adding streams to event definitions with no streams assigned or with stream categories that need to be mapped to stream IDs./nocl just a POC for now
Description
Motivation and Context
How Has This Been Tested?
Screenshots (if appropriate):
Types of changes
Checklist: