Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix _from_ema_to_offsets #15

Open
alexandermorgan opened this issue Nov 8, 2021 · 1 comment
Open

Fix _from_ema_to_offsets #15

alexandermorgan opened this issue Nov 8, 2021 · 1 comment
Assignees

Comments

@alexandermorgan
Copy link
Collaborator

This method works and is useful but should be renamed to _ema2measures to better represent what it does. This also reveals that some ema addresses are faulty, such as observations 4701, 4702, and 4710. It's very helpful that this reveals these issues, but perhaps problematic lines should be dropped by default. The problem lines are the ones where the new "end" column == "". This is caused by the ffill functionality not working as intended (seems to be operating on the wrong axis).

@alexandermorgan alexandermorgan self-assigned this Nov 8, 2021
@RichardFreedman
Copy link
Collaborator

There are indeed broken EMA references in CRIM (partly the result of fussy JS and selection tool). Having a way to identify those would indeed be helpful. Fixing them is tedious, however. I agree that dropping them from DFs would be a reasonable option for some analysis tools.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants