Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix the file free space manager infinite loop bug #5121

Open
derobins opened this issue Nov 14, 2024 · 0 comments
Open

Fix the file free space manager infinite loop bug #5121

derobins opened this issue Nov 14, 2024 · 0 comments
Assignees
Labels
Component - C Library Core C library issues (usually in the src directory) Component - Parallel Parallel HDF5 (NOT thread-safety) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Milestone

Comments

@derobins
Copy link
Member

derobins commented Nov 14, 2024

REF: https://github.com/HDFGroup/hdf5/blob/develop/testpar/t_filters_parallel.c#L10059-L10066

/*
 * TODO: Ideally, use persistent free space management. However,
 * this occasionally runs into an infinite loop in the library's
 * free space management code, so don't persist free space for now
 * until that is fixed.
 */
VRFY((H5Pset_file_space_strategy(fcpl_id, H5F_FSPACE_STRATEGY_PAGE, false, 1) >= 0),
     "H5Pset_file_space_strategy succeeded");

When the parallel compression tests (testpar/t_filters_parallel.c) are run with persistent free space management enabled, an infinite loop in the file free space managers will sometimes be encountered. Quick initial investigation seems to show this to be an issue where the same block of free space is getting repeatedly allocated and de-allocated, but more investigation is needed.

@derobins derobins added Component - C Library Core C library issues (usually in the src directory) Component - Parallel Parallel HDF5 (NOT thread-safety) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub labels Nov 14, 2024
@derobins derobins added this to the 2.0.0 milestone Nov 14, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Component - C Library Core C library issues (usually in the src directory) Component - Parallel Parallel HDF5 (NOT thread-safety) Priority - 1. High 🔼 These are important issues that should be resolved in the next release Type - Bug / Bugfix Please report security issues to [email protected] instead of creating an issue on GitHub
Projects
None yet
Development

No branches or pull requests

2 participants