Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make config flipped attribute consistent #297

Open
boeckhoff opened this issue May 28, 2020 · 2 comments
Open

make config flipped attribute consistent #297

boeckhoff opened this issue May 28, 2020 · 2 comments

Comments

@boeckhoff
Copy link
Collaborator

for motors flipped value is either true or false,
for encoders flipped value is either 1 or -1

this should be consistent, I suggest using true/false for both.

@JotaroS
Copy link
Collaborator

JotaroS commented May 28, 2020

can you also point to the code or file to be fixed?

@boeckhoff
Copy link
Collaborator Author

boeckhoff commented May 28, 2020

in generated config.hpp under firmware/include/config/config.hpp properties look as follows:

const float encoderFlipped[] = { -1, -1, 1, -1, -1, 1 };

const bool motorFlipped[] = { true, true, false, true, true, false };

so files to modify would be
utils/scripts/generateHardwareConfig.js
and firmware files that access the flipped properties

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants