Make MuMech_OrbitExtensions public, or expose TimeOfAscendingNode/TimeOfDescendingNode differently

[markjfisher]

Thanks for the update fixing the planar change, however, I think there's a small bug.

The class MuMech_OrbitExtensions that wraps the 2 public methods I'd like to access in kOS-Astrogator is still internal static, so I'm not seeing the Orbit extensions to be able to use them.

[HebaruSan]

Oh, I didn't realize that. I thought you just needed the access modifiers of the individual functions changed (which they were).

In the meantime, could you use TimeOfPlaneChange? That's one of my functions and it's in the public static PhysicsTools class.

[markjfisher]

kOS-Astrogator exposes both so people can use which ever one they want, so it'd be a breaking change to only offer the next plane change, though I like that this is a thing (and will probably offer them as extensions too), as I often do in my own scripts:

set t to max(addons:astrogator:timeOfShipAN, addons:astrogator:timeOfShipDN).

note I prefer the max rather than soonest just in case I'm really close to the node and need time to spin etc.
From scripts it's safer to take the max and warpto so it's got time to align to the node.

I'll keep my copy of the code around for now. It's only a nice to have to use Astrogator code to reduce the amount of duplicated code, but if you do plan further changes at some point, this would be nice to fix in with those if possible.

[markjfisher]

Awesome. I've released kOS-Astrogator with these changes.