Allow disabling country restrictions

[FloEdelmann]

Use case

While many municipalities in Germany decide to not add reference numbers to fire hydrants, some indeed do. The AddFireHydrantRef quest however is never shown in Germany and can't be enabled.

Note

As a workaround, the AddGenericRef quest filter can be edited (which results in a "Specify refs" changeset comment).

Proposed Solution

1. Add a global setting "Disable country restrictions". This may be too heavy-handed.
2. Add a "Disable country restriction" quest setting to the AddFireHydrantRef quest.
3. Add a "Disable country restriction" quest setting automatically to all country-restricted quests.
4. Allow manually editing country restrictions in the AddFireHydrantRef quest.
5. Allow manually editing country restrictions automatically in all country-restricted quests.

I'd favor option 3.

Previous discussions:

• Street furniture ref quest #531 (comment)
• Anregung: Filter "Niemals in Deutschland gezeigt" entfernen für Feuerwehr-Hydranten #618

[Helium314]

I don't think letting users override country restrictions is a good idea. Some restrictions do exist because SC(EE) tagging is not wanted by community, e.g. the housenumber quest in Italy.

[FloEdelmann]

Some restrictions do exist because SC(EE) tagging is not wanted by community

Okay, so options 1, 3 and 5 are ruled out. But would implementing this specifically for the AddFireHydrantRef quest (and maybe others by request) be considered fine? I.e. options 2 or 4?

[rusty-snake]

Like the surface quest where you can enable generic answers.

[mnalis]

But would implementing this specifically for the AddFireHydrantRef quest (and maybe others by request) be considered fine?

That quest in particular would seem fine to me to have override to be enabled in any country.

Also, this being EE, I might also like "generic country limit override" that can be enabled only if Expert mode is turned on, and even then only after showing big fat warning/confirmation screen warning like:

"There are good reasons why certain quests are disabled in certain countries! Before enabling this override, You MUST verify with local community where edits are being made whether it is OK to tag that data in a way that this quest does there; otherwise you risk mapping against established community consensus and have complaints filed against your edits!

Do not enable this override unless you are absolutely sure what you're doing!"

(and if expert mode is being disabled, that override should be turned off automatically too)

[Helium314]

I think quest settings would be a simple and safe approach.

Do not enable this override unless you are absolutely sure what you're doing!"

Hmm, I don't trust all users to follow this.
A generic override would also be a bit dangerous, e.g. if you want to enable the fire hydrant ref quest, you would also enable the housenumber quest in Italy.

So I would still prefer having this implemented per quest (though it's much more work than a simple on/off switch).

[mnalis]

So I would still prefer having this implemented per quest (though it's much more work than a simple on/off switch).

Yes, that would be even better, I agree - but as you note: much more work.

I'd still prefer such per-quest country override to have limitations as outlined above (i.e. only be shown if Expert mode is also on, and to display a warning before overriding the quest country selection limit, etc.)