Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

blackhole-2ch 0.6.1 #200940

Merged
merged 2 commits into from
Feb 8, 2025
Merged

blackhole-2ch 0.6.1 #200940

merged 2 commits into from
Feb 8, 2025

Conversation

devinroth
Copy link
Contributor

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

@devinroth
Copy link
Contributor Author

Note: I've moved away from using the kill command to reboot CoreAudio. Instead Apple recommends restarting the computer. Restarting it much more reliable because the kill script is unreliable. What's the best method for brew? I'm fine if it stays. Up to you.

@daeho-ro daeho-ro changed the title Update blackhole-2ch.rb blackhole-2ch 0.6.1 Feb 8, 2025
@bevanjkay
Copy link
Member

@devinroth do you have a link to any documentation from Apple with the recommendation, we can remove the script from the Cask, and add a reboot caveat.

@bevanjkay
Copy link
Member

I can't push directly to the PR, because it's not opened from a branch.

cask "blackhole-2ch" do
  version "0.6.1"
  sha256 "c829afa041a9f6e1b369c01953c8f079740dd1f02421109855829edc0d3c1988"

  url "https://existential.audio/downloads/BlackHole2ch-#{version}.pkg"
  name "BlackHole 2ch"
  desc "Virtual Audio Driver"
  homepage "https://existential.audio/blackhole/"

  # The upstream website doesn't provide version information. We check GitHub
  # releases as a best guess of when a new version is released.
  livecheck do
    url "https://github.com/ExistentialAudio/BlackHole"
    strategy :github_latest
  end

  pkg "BlackHole2ch-#{version}.pkg"

  uninstall quit:    "com.apple.audio.AudioMIDISetup",
            pkgutil: "audio.existential.BlackHole2ch"

  # No zap stanza required

  caveats do
    reboot
  end
end

@bevanjkay bevanjkay mentioned this pull request Feb 8, 2025
8 tasks
@devinroth
Copy link
Contributor Author

I originally learned the reboot recommendation from an apple developer so I'm not exactly sure where it is in the official documentation.

It's mentioned here.

https://developer.apple.com/documentation/coreaudio/creating-an-audio-server-driver-plug-in

Let me know if that works for you.

Add reboot command.
@bevanjkay bevanjkay enabled auto-merge February 8, 2025 05:04
@bevanjkay bevanjkay merged commit d8d9f79 into Homebrew:master Feb 8, 2025
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants