Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libreoffice-still 24.8.4 #200942

Merged
merged 1 commit into from
Feb 8, 2025
Merged

libreoffice-still 24.8.4 #200942

merged 1 commit into from
Feb 8, 2025

Conversation

samford
Copy link
Member

@samford samford commented Feb 8, 2025

Important: Do not tick a checkbox if you haven’t performed its action. Honesty is indispensable for a smooth review process.

In the following questions <cask> is the token of the cask you're submitting.

After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

This updates libreoffice-still to 24.8.4 (again), now that it has been officially released. As with libreoffice, the livecheck block is incorrectly returning 24.2.7 as the newest Still version because upstream hasn't updated the libreoffice.org Release Notes page yet.

This also updates the livecheck block to use the libreoffice check (inheriting the url and regex), along with the previous strategy block that uses the second-highest version. This means that we need to make sure that the libreoffice livecheck block always checks a page that lists both the latest Fresh and Still versions.

This depends on the related libreoffice PR (#200939), so I'm creating this as a draft until that's merged (and will rebase afterward).

@samford samford added the livecheck Issues or PRs related to livecheck label Feb 8, 2025
@bevanjkay bevanjkay marked this pull request as ready for review February 8, 2025 03:44
@bevanjkay bevanjkay enabled auto-merge February 8, 2025 03:44
This updates `libreoffice-still` to 24.8.4 (again), now that it has
been officially released. As with `libreoffice`, the `livecheck` block
is incorrectly returning 24.2.7 as the newest Still version because
upstream hasn't updated the libreoffice.org Release Notes page yet.

This also updates the `livecheck` block to use the `libreoffice` check
(inheriting the `url` and `regex`), along with the previous `strategy`
block that uses the second-highest version. This means that we need
to make sure that the `libreoffice` `livecheck` block always checks a
page that lists both the latest Fresh and Still versions.
@samford samford force-pushed the libreoffice-still-24.8.4 branch from f84fbeb to 42f85bb Compare February 8, 2025 03:46
@bevanjkay bevanjkay merged commit 600b4c7 into master Feb 8, 2025
11 checks passed
@bevanjkay bevanjkay deleted the libreoffice-still-24.8.4 branch February 8, 2025 04:18
@khipp
Copy link
Member

khipp commented Feb 8, 2025

@samford libreoffice-still-language-pack might also need a livecheck revision since it depends on this cask but returns version 25.2.0 (see #200953).

@samford
Copy link
Member Author

samford commented Feb 8, 2025

@khipp Oh yeah, I meant to take care of the -language-pack casks but it was a bit late and I forgot, so thanks for surfacing this issue.

libreoffice-still-language-pack references libreoffice-still which references libreoffice and it looks like I overlooked something in the chained reference implementation (i.e., the former inherits the url and regex like it should but not the strategy block from libreoffice-still). I'll replace the cask reference in libreoffice-still as a short-term workaround (as part of downgrading the language pack to 24.8.4) but I'll look into why it's not working as expected (and make sure to expand test coverage to include this case).

I'll have a PR up to downgrade libreoffice-still-language-pack once I finish downloading the hundreds of files to compute the sha256 values 😭

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
livecheck Issues or PRs related to livecheck
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants