Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG]: **All** ESM packages need .js extension #2199

Open
nmerget opened this issue Feb 11, 2025 · 2 comments
Open

[BUG]: **All** ESM packages need .js extension #2199

nmerget opened this issue Feb 11, 2025 · 2 comments
Labels
user-reported Issues identified outside of the core team

Comments

@nmerget
Copy link

nmerget commented Feb 11, 2025

Project

other

Browser

Chrome, Safari, Firefox

Operating system

Windows

Description

You add .js extension to some file in this pr. But there are additional files in common/module like this.

I guess there are some missing configurations in tsconfig.json otherwise it would throw an error, linting the files.

You can check the error in our repo:

Error: Cannot find module '/__w/mono/mono/node_modules/accessibility-checker/mjs/lib/common/config/ACConstants' imported from /__w/mono/mono/node_modules/accessibility-checker/mjs/lib/common/config/ACConfigManager.js

Steps to reproduce

Add import { close, getCompliance } from 'accessibility-checker'; to an ESM project, and use it like this.

@tombrunet
Copy link
Member

Apologies. I did test the built module with an ESM project and for some reason these did not fail. I'll try to find the remaining ones and get a fix out hopefully within the week.

@nmerget
Copy link
Author

nmerget commented Feb 11, 2025

No problem, thank you for the quick response and for the accessibility-checker :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
user-reported Issues identified outside of the core team
Projects
None yet
Development

No branches or pull requests

3 participants