New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

optimizer.zero_grad() #58

Open

lingorX opened this issue Jan 12, 2023 · 1 comment

lingorX commented Jan 12, 2023

Hi,

It seems that optimizer.zero_grad() is forgotten to call here.

Or perhaps I miss something.

Contributor

SlongLiu commented Feb 2, 2023

Thanks for your good question. It can be viewed as a bug in out implementation, but with little influence on the final performance.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment