Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add social links to clubs and councils #23

Closed
nishantwrp opened this issue Apr 17, 2020 · 7 comments · Fixed by #32
Closed

Add social links to clubs and councils #23

nishantwrp opened this issue Apr 17, 2020 · 7 comments · Fixed by #32
Assignees

Comments

@nishantwrp
Copy link
Collaborator

Add fields like website, facebook page to each club and council models

@krashish8
Copy link
Member

krashish8 commented Apr 18, 2020

Add the fields website_url, facebook_url, twitter_url, instagram_url, linkedin_url, youtube_url to Clubs Detail endpoint and Councils Detail endpoint. The field will be null/blank by default if it doesn't exist for the club/council.

Also, since every council has a fest, we can add fest_url to the Council Detail endpoint too.

In the frontend, display the corresponding social icon with href having the corresponding URL, if the field is not null or blank.

Any suggestions or modifications? @nishantwrp @nishantkr18

@krashish8 krashish8 self-assigned this Apr 18, 2020
@nishantwrp
Copy link
Collaborator Author

LGTM! But I'm not sure about the `fest_url! What do you think @shivanshs9?

@nishantkr18
Copy link
Collaborator

Yeah.. I too agree.. with the icon, it might look good!

@shivanshs9
Copy link
Collaborator

"fest_url" would be good to have, but then again there are so many URLs for fest too... FB, website, IG etc
It's better to just create a new Fest model

@shivanshs9
Copy link
Collaborator

Or maybe have a OrganizingBody model I discussed with @nishantwrp to make it even more abstract and optionally link it with the council.

@nishantwrp
Copy link
Collaborator Author

Yeah, So I think we can drop fest_url for now. That can be covered when we work on #27.

@krashish8
Copy link
Member

krashish8 commented Apr 19, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants