Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Specification of Sets #34

Closed
apdavison opened this issue Oct 14, 2014 · 14 comments
Closed

Specification of Sets #34

apdavison opened this issue Oct 14, 2014 · 14 comments
Assignees
Milestone

Comments

@apdavison
Copy link
Member

Sets are intended to group populations and, possibly, define and group sub-populations. They were not fully specified by the task force.

@apdavison apdavison added this to the Version 1.0 milestone Oct 14, 2014
@apdavison
Copy link
Member Author

For V1, the NineML standards meeting in Antwerp agreed to adopt the syntax from the "technical paper" for version 1 (i.e. , etc., no sub-sets). Handling more complex scenarios is postponed to version 2.

@tclose
Copy link
Contributor

tclose commented Oct 15, 2014

NineML standards meeting:

We have agreed on the following format for union of populations

<Set name="AllNeurons">
  <Concatenate>
    <Item index="0">Golgis</Item>
    <Item index="1">Granules</Item>
  </Concatenate>
</Set>

Subsets are deferred to version 2, see #38

@tclose tclose self-assigned this Oct 15, 2014
@tclose
Copy link
Contributor

tclose commented Oct 22, 2014

Set doesn't seem to be the right name for this considering we are trying to conserve cell indices...

@tclose tclose assigned apdavison and unassigned tclose Oct 22, 2014
@tclose
Copy link
Contributor

tclose commented Nov 4, 2014

In the google hangout last Friday we decided to reassign the name Group (the old concept of Group may be reintroduced as Network in future versions) for this concept instead of Set. However, as we have already been talking about using the name ComponentGroup in version 2.0 I have proposed that we call this a PopulationGroup in the latest draft of the spec. Any objections?

@apdavison
Copy link
Member Author

PopulationGroup sounds like a group of populations, whereas we are really talking about a group of cells, so perhaps CellGroup would be better?

@tclose
Copy link
Contributor

tclose commented Nov 4, 2014

Yeah, in the case where we are just allowing concatenation of populations PopulationGroup would make sense but where we are selecting sub-populations and concatenating them together it wouldn't really. The difference between a CellGroup and a Population could be pretty confusing though. Not sure, how about something like PopulationsCombined, PopulationsSelection... still not quite right

@tclose
Copy link
Contributor

tclose commented Nov 5, 2014

How about <CellSelection>, or actually I am coming around to <PopulationSelection> as it can be either a selection of populations or a selection from a population (or both) in version 2.0?

@apdavison
Copy link
Member Author

<PopulationSelection> sounds good.

@tclose
Copy link
Contributor

tclose commented Nov 7, 2014

This is now implemented in the python library with PR #54 (assuming Andrew is okay with it).

@tclose tclose assigned iraikov and unassigned apdavison Nov 7, 2014
@apdavison
Copy link
Member Author

It's fine with me. Another idea for the name: how about simply <Selection>?

@tclose
Copy link
Contributor

tclose commented Nov 8, 2014

Yeah, I like <Selection>. I will change it in the spec and see if anyone has any problems with it when we send it round

@iraikov
Copy link
Contributor

iraikov commented Nov 10, 2014

It is not clear to me what happens if several items in a concatenate declaration refer to the same population, e.g.:

<Selection name="AllNeurons">
  <Concatenate>
    <Item index="0">Excitatory</Item>
    <Item index="1">Excitatory</Item>
    <Item index="2">Inhibitory</Item>
  </Concatenate>
</Selection>

Are repeated elements in the set preserved, and is it that two copies of the Excitatory population are to be created in this example?

If so, perhaps it is more appropriate to call this object a "population map" or "population dictionary" since it also serves to assign indices to populations.

@ajc158
Copy link

ajc158 commented Nov 10, 2014

It would seem sensible that there are simply several references to the same
objects. I think 'Selection' is better than 'map' or 'dictionary', as it
has a suitable meaning to non-programmers even if it is not as correct.

On 10 November 2014 21:36, Ivan Raikov [email protected] wrote:

It is not clear to me what happens if several items in a concatenate
declaration refer to the same population, e.g.:

Excitatory
Excitatory
Inhibitory

Are repeated elements in the set preserved, and is it that two copies of
the Excitatory population are to be created in this example?

If so, perhaps it is more appropriate to call this object a "population
map" or "population dictionary" since it also serves to assign indices to
populations.


Reply to this email directly or view it on GitHub
#34 (comment).

Alex Cope
Research Associate
Behavioural and Evolutionary Theory Lab
Department of Computer Science, University of Sheffield
www.alexcope.co.uk

@iraikov
Copy link
Contributor

iraikov commented Nov 10, 2014

That's fine, as long as it is clearly defined somewhere. I agree that 'Selection' is a better name in this case,
my suggestion about 'map' was in case somebody wanted to make copies of repeated populations.

On Mon, Nov 10, 2014 at 6:43 PM, Alex Cope [email protected] wrote:

It would seem sensible that there are simply several references to the
same
objects. I think 'Selection' is better than 'map' or 'dictionary', as it
has a suitable meaning to non-programmers even if it is not as correct.

On 10 November 2014 21:36, Ivan Raikov [email protected] wrote:

It is not clear to me what happens if several items in a concatenate
declaration refer to the same population, e.g.:

Excitatory
Excitatory
Inhibitory

Are repeated elements in the set preserved, and is it that two copies of
the Excitatory population are to be created in this example?

If so, perhaps it is more appropriate to call this object a "population
map" or "population dictionary" since it also serves to assign indices
to
populations.


Reply to this email directly or view it on GitHub
#34 (comment).

Alex Cope
Research Associate
Behavioural and Evolutionary Theory Lab
Department of Computer Science, University of Sheffield
www.alexcope.co.uk


Reply to this email directly or view it on GitHub
#34 (comment).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants