Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Filter does not apply on "re-used" properties #736

Open
mdeweerd opened this issue Nov 27, 2024 · 2 comments
Open

[BUG] Filter does not apply on "re-used" properties #736

mdeweerd opened this issue Nov 27, 2024 · 2 comments
Assignees

Comments

@mdeweerd
Copy link

I guess this is somewhere between a bug and a feature.

I use the following filter for certain BOMs:

filters:
  - name: only_lcsc_parts
    comment: Only parts with LCSC code
    type: generic
    include_only:
      - column: LCSC#
        regex: ^C\d+ 

However, this filter works on the components without using the reuseable information.

I have R11 and R15 and others that have 10k values.
However, R11 did not have the 'lcsc#' property field and was excluded from the BOM.

The typical use case is that when certain fields are empty, that they inherit their value from other components where this value is defined.

I am not sure what the best method is to cope with this as the field names are not all predetermined.

Prevention wise, I think a FieldCheck is appropriate to make sure all these fields are filled - either with a value number or with a "NULL" value.

@set-soft
Copy link
Member

Relying on inherited values from other components is a bad idea, you can use it, yes, but if it fails just don´t do this.

Yes, "Check Fields" can be used to verify issues.

The "Field Modify", "Spec to Field", "Field Rename" and "Expand Text Variables" can be used along with the KiCad Dialog that allows massive changes to fill your gaps.

Also: I usually create local libs containing the components I'll use in a project and use these components. So I don't use a generic R for a 10k resistor, I use a 10k resistor that contains all the information, including the manufacturer and P/N. KiCad can update the components from the lib, and in fact report if they got out of sync.

@set-soft
Copy link
Member

BTW: If you are using this feature, why did you choose a component that could be excluded to be the reference for the others? Just move the data to a component that you'll never exclude

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants