From 816999403ba4695f6e67a2a04f1fd78660792774 Mon Sep 17 00:00:00 2001 From: Tom Willemsen Date: Tue, 26 Nov 2024 18:05:07 +0000 Subject: [PATCH] Correctly overwrite error_log_func This is not a nice API, but doing the minimal refactor for the moment. --- src/genie_python/genie_epics_api.py | 2 +- tests/test_genie_epics_api.py | 3 +++ 2 files changed, 4 insertions(+), 1 deletion(-) diff --git a/src/genie_python/genie_epics_api.py b/src/genie_python/genie_epics_api.py index c006d583..0bc99f25 100644 --- a/src/genie_python/genie_epics_api.py +++ b/src/genie_python/genie_epics_api.py @@ -74,7 +74,7 @@ def __init__( else: self._environment_details = environment_details - Wrapper.errorLogFunc = self.logger.log_ca_msg + Wrapper.error_log_func = self.logger.log_ca_msg # disable CA error messages to console from disconnected PVs import ctypes diff --git a/tests/test_genie_epics_api.py b/tests/test_genie_epics_api.py index 31a5d221..1016598b 100644 --- a/tests/test_genie_epics_api.py +++ b/tests/test_genie_epics_api.py @@ -173,6 +173,9 @@ def test_GIVEN_pv_name_WHEN_pv_not_connected_THEN_get_pv_alarm(self): self.assertEqual(self.api.get_pv_alarm("DISCONNECTED_PV"), "UNKNOWN") + def test_GIVEN_api_is_imported_THEN_error_log_func_overwritten_on_wrapper(self): + self.assertEqual(self.mock_wrapper.error_log_func, self.api.logger.log_ca_msg) + class TestEpicsApiSetInstrumentName(unittest.TestCase): def setUp(self):