Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enhance resource location detection. #4

Open
mattsgarrison opened this issue May 6, 2013 · 3 comments
Open

Enhance resource location detection. #4

mattsgarrison opened this issue May 6, 2013 · 3 comments
Assignees

Comments

@mattsgarrison
Copy link
Contributor

app.resources_dirs defaults to /resources but this can be configured per project. Motion-rubberstamp should search for icons in all paths declared by resource_dirs.

@ghost ghost assigned mattsgarrison May 6, 2013
@mattsgarrison
Copy link
Contributor Author

resource_dirs should be an array of strings (paths), so everywhere '/resources' is explicitly called, it will need to iterate over resource_dirs and concatenate that path with the icon filename instead.

If icons are found in non-default locations, they would currently install in the same directory. Perhaps creating a new folder ./rubberstamp or maybe ./original_icons to contains the originals in whichever directory any icons are found in would be a better solution than polluting the current directory with the "working set" of modified icons and their '*_base.png' counterparts.

@GantMan
Copy link
Member

GantMan commented May 7, 2013

I strongly agree with keeping Rubberstamp files inside of a rubberstamp folder. I feel it helps identify where new images came from, for an existing project. It will make sense to most.

Added as issue #15

@mattsgarrison
Copy link
Contributor Author

Currently motion-rubberstamp gets very angry if a ./resources folder is not present at all. Enhancements to resource detection should consider what happens if nothing is found.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants