Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Correct "trap placed" log #204

Closed
Ido-Barnea opened this issue Feb 21, 2024 · 0 comments · Fixed by #215
Closed

Correct "trap placed" log #204

Ido-Barnea opened this issue Feb 21, 2024 · 0 comments · Fixed by #215
Assignees
@Ido-Barnea
Labels
bug Something isn't working

Comments

@Ido-Barnea
Copy link
Owner

Describe the bug

When placing a trap on the board, the log writes the placement coordinates as numbers (e.g. 2,3) instead of coordinates (e.g. b,3)

Steps To Reproduce

  1. But trap from shop
  2. Place trap anywhere on the board
  3. See log message

Expected behavior

Trap placement coordinates should be normal chess coordinates.
@Ido-Barnea Ido-Barnea added the bug Something isn't working label Feb 21, 2024
@Ido-Barnea Ido-Barnea added this to the 0.1.0 milestone Feb 21, 2024
@Ido-Barnea Ido-Barnea self-assigned this Feb 21, 2024
Ido-Barnea added a commit that referenced this issue Feb 21, 2024
@Ido-Barnea
[#204] Fixed trap log
b9355ce
@Ido-Barnea Ido-Barnea linked a pull request Feb 21, 2024 that will close this issue
[#204] Fixed trap log #215
Merged
Ido-Barnea added a commit that referenced this issue Feb 21, 2024
@Ido-Barnea
Merge pull request #215 from Ido-Barnea/204-correct-trap-placed-log
8fa8fd3 
[#204] Fixed trap log
Monkey-bored pushed a commit that referenced this issue Feb 28, 2024
@Ido-Barnea @Monkey-bored
[#204] Fixed trap log
2d06bab
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Ido-Barnea Ido-Barnea

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#204] Fixed trap log Ido-Barnea/Chess-But-Better
1 participant
@Ido-Barnea