Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve test coverage #264

Open
1 task
Ido-Barnea opened this issue Mar 29, 2024 · 1 comment · Fixed by #288, #291 or #296
Open
1 task

Improve test coverage #264

Ido-Barnea opened this issue Mar 29, 2024 · 1 comment · Fixed by #288, #291 or #296
Assignees
@Monkey-bored
Labels
testing Related to testing
Milestone
0.2.0

Comments

@Ido-Barnea
Copy link
Owner

Ido-Barnea commented Mar 29, 2024 •
edited
Loading

Requested Changes

  • Increase test coverage of logic files to a minimum of 95%.

Additional Information

To assess current test coverage, execute Jest with the --coverage flag and inspect the generated report in the test-coverage directory.
@Ido-Barnea Ido-Barnea added infra Changes and improvements to the project's infrastructure testing Related to testing labels Mar 29, 2024
@Ido-Barnea Ido-Barnea added this to the 0.2.0 milestone Mar 29, 2024
@Ido-Barnea Ido-Barnea removed the infra Changes and improvements to the project's infrastructure label Mar 30, 2024
@Ido-Barnea Ido-Barnea self-assigned this Apr 21, 2024
@Ido-Barnea Ido-Barnea linked a pull request Apr 22, 2024 that will close this issue
Wrote more unit tests #288
Merged
@Ido-Barnea Ido-Barnea reopened this Apr 22, 2024
@Ido-Barnea Ido-Barnea linked a pull request Apr 22, 2024 that will close this issue
Wrote more unit tests #291
Merged
@Ido-Barnea Ido-Barnea reopened this Apr 22, 2024
@Ido-Barnea Ido-Barnea mentioned this issue Apr 23, 2024
Closed
Monkey-bored added a commit that referenced this issue Apr 28, 2024
@Monkey-bored
[#264] Added tests for friendly fire rule
3d1b468
@Monkey-bored Monkey-bored linked a pull request Apr 28, 2024 that will close this issue
[#264] Added tests for friendly fire rule #296
Merged
Monkey-bored added a commit that referenced this issue Apr 28, 2024
@Monkey-bored
[#264] Added Experience on kill test and minor fix
35b381c
Monkey-bored added a commit that referenced this issue Apr 28, 2024
@Monkey-bored
[#264] minor format fixes
5de0641
Monkey-bored added a commit that referenced this issue Apr 28, 2024
@Monkey-bored
[#264] Removed unused import
82f427c
Monkey-bored added a commit that referenced this issue Apr 29, 2024
@Monkey-bored
Merge pull request #296 from Ido-Barnea/264-improve-test-coverage
8b1843b 
[#264] Added tests for friendly fire rule
@Monkey-bored Monkey-bored reopened this Apr 29, 2024
@Ido-Barnea
Copy link
Owner Author

@Monkey-bored could you please update your progress regarding this issue? What is our current test coverage?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monkey-bored Monkey-bored

Labels
testing Related to testing
Projects
None yet
Milestone
0.2.0
2 participants
@Ido-Barnea @Monkey-bored