Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of unnecessary switch statements #90

Closed
Monkey-bored opened this issue Nov 30, 2023 · 0 comments · Fixed by #96
Closed

Get rid of unnecessary switch statements #90

Monkey-bored opened this issue Nov 30, 2023 · 0 comments · Fixed by #96
Assignees
@Monkey-bored
Labels
infra Changes and improvements to the project's infrastructure

Comments

@Monkey-bored
Copy link
Collaborator

Monkey-bored commented Nov 30, 2023 •
edited by Ido-Barnea
Loading

It seems like the type Position stores coordinates and a string board (The ID of the board),
instead store the actual Board (type ChessBoard) and get rid of all the unnecessary switches.
@Ido-Barnea Ido-Barnea changed the title Get rid of unnecessary switch(es) Get rid of unnecessary switch statements Nov 30, 2023
@Ido-Barnea Ido-Barnea added the infra Changes and improvements to the project's infrastructure label Dec 8, 2023
Monkey-bored added a commit that referenced this issue Dec 22, 2023
@Monkey-bored
[#90] Got rid of repetitive switch statements
a12f3c4
@Monkey-bored Monkey-bored linked a pull request Dec 22, 2023 that will close this issue
[#90] Got rid of repetitive switch statements #96
Merged
Monkey-bored added a commit that referenced this issue Dec 22, 2023
@Monkey-bored
Merge pull request #96 from Ido-Barnea/90-get-rid-of-unnecessary-swit…
f11a97c 
…ch-statements

[#90] Got rid of repetitive switch statements
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Monkey-bored Monkey-bored

Labels
infra Changes and improvements to the project's infrastructure
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[#90] Got rid of repetitive switch statements Ido-Barnea/Chess-But-Better
2 participants
@Ido-Barnea @Monkey-bored