Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Seperate Desktop/Panel/Pane Icon Sizes #480

Closed
ghost opened this issue Mar 9, 2015 · 13 comments
Closed

Seperate Desktop/Panel/Pane Icon Sizes #480

ghost opened this issue Mar 9, 2015 · 13 comments
Labels
Milestone

Comments

@ghost
Copy link

ghost commented Mar 9, 2015

Would you please look into adding a seperate icon size setting field for the Desktop and each file manager Panel? It would be a great enhancement or feature!!

@ghost ghost changed the title Seperate Desktop Icon Size Settings [Feature Request/ Enhancement] Seperate Desktop Icon Size Settings Mar 9, 2015
@ghost ghost changed the title [Feature Request/ Enhancement] Seperate Desktop Icon Size Settings [Feature Request/ Enhancement] Seperate Desktop And Indavidual Panel Icon Size Settings Mar 9, 2015
@IgnorantGuru IgnorantGuru added this to the far milestone Mar 9, 2015
@Vladimir-csp
Copy link

Given the new changes to thumbnail sizes, I think these separate size controls would be right:

  • Main pane (icon mode)
  • Main pane (list and table mode)
  • Toolbars
  • Side panes
  • Desktop

Current "Large icons"/"Small icons" may be confusing anyway.

@IgnorantGuru
Copy link
Owner

I can see the usefulness of these, but as noted elsewhere, these changes would not be as simple as adding the settings, because the code is not designed for it. eg icons are loaded and cached with object refs used, and if different panes are using different sizes, multiple sizes may need to be cached. And the code that loads the icons would need to be pane/panel-aware, etc. Currently all the code uses only 3 icon sizes (small, large, and toolbar), and this would require a dozen or more sizes to be stored and acted on.

First step would be some research to see what is affected in the code, and how the icon cache/references are implemented.

@IgnorantGuru
Copy link
Owner

Also noting #94 wrt this.

@IgnorantGuru IgnorantGuru changed the title [Feature Request/ Enhancement] Seperate Desktop And Indavidual Panel Icon Size Settings Seperate Desktop/Panel/Pane Icon Sizes Apr 5, 2015
@ghost
Copy link
Author

ghost commented Apr 6, 2015

Ahhh, gotcha, that makes since. I wish I could code better as I would love to tackle this for you. XD But my skill set is at zenity/bash level at this time. =/ Though I'm working to learn python/gtkbuilder. I figure once I'm more comfertable with those two transitioning to C/C++/gtkbuilder would be easyer. I would apreciate any insight as to how you began coding and where I may start to get to your level because helping out would be awesome! PS- Should I close this or keep it open for you?

IgnorantGuru pushed a commit that referenced this issue Apr 6, 2015
 #94

also increase max side pane icon size to 48x48
@IgnorantGuru
Copy link
Owner

Yes please leave this open - some of it can be considered. I was just explaining that it's not a simple change and would require research and redesign. iirc SpaceFM caches up to two icon sizes for each mime type on demand. Then when it needs an icon in the file lists or on the desktop, it just adds a reference to these cached objects. So having too many different sizes wouldn't be easy and would affect speed and memory use. The current design provides two customizable sizes for use: large and small.

I just added a 'Large Icons' option to the hand branch as detailed here. That should help with changing icon sizes on the fly from small to large in those views.

As for the desktop, the cache issue is the main reason for the desktop sharing the same large icon size. The prospect of a separate setting would require research before I could comment on how feasible it is.

Sorry I don't have any coding advice - I learned C long ago (in a galaxy far away), and I learned GTK by writing SpaceFM. As far as working on SpaceFM, I don't accept a lot of contributions, unless it's a small thing, because it's a lot of work to integrate and review code contributions and maintain stability. SpaceFM is a prototype which was built from another program (PCManFM 0.5, before it went to gvfs), so the code is a bit difficult to work with. I don't recommend trying unless you're very determined. Working on this would not be a good way to learn anything. ;)

@IgnorantGuru
Copy link
Owner

Actually since there are relatively few icons on the desktop (compared to dirs containing thousands of files), it might be feasible to skip the cache and just load the icons. GTK usually has an icon cache running too. So the seperate setting for desktop icon sizes might be feasible. Would probably just be a matter of changing the icon loading functions. Just noting this.

@Vladimir-csp
Copy link

since there are relatively few icons on the desktop (compared to dirs containing thousands of files)

Never underestimate some users` bright talent at shitting all over their destkops :) And size of desktop is not the limit...

@ghost
Copy link
Author

ghost commented Apr 6, 2015

Aight, thanks for the advice!! And I must agree with @Vladimir-csp on his point. My mother put well over 200 files/folders on her desktop. T.T Made me cringe every time I saw that mess. She moved to a Note3 and has kept it clean so far. Also, on the average i'd bet it'd work fine to use the GTK cache with a seperate video icon cache as you mentioned to handel the desktop icon sizes. That would largly address my preferences/needs as well since i'm not looking to change the icon size indavidually in each pane but the sizes for the desktop seperae from the file managers'.

@ghost
Copy link
Author

ghost commented Apr 6, 2015

An addendum to my last reply, by using a larger "Small Icons" setting,96x96, and using a smaller "Large Icons" setting,64x64, allows for what i'm aiming for. That and coupling it by changing my view type in the file manager to compact rather than icon allows me to have small desktop icons with larger file manager icons. Though, having the text to the right is somewhat not my preference.XD Still, untill there is a change in the code it is closer to what i'm gunning for. =]

@IgnorantGuru
Copy link
Owner

Noting #396

@ghost
Copy link
Author

ghost commented Sep 28, 2018

Closed since this isn't being maintained by @IgnorantGuru

@ghost ghost closed this as completed Sep 28, 2018
@ryanmusante
Copy link

Sadness. Where art thou, @IgnorantGuru?

@ghost
Copy link
Author

ghost commented Sep 28, 2018

@ryanmusante Doing other stuff I assume. I think someone else took over but don't recall.

This issue was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants