Fix crash when unmounting volumes #821

yut23 · 2024-09-28T23:29:43Z

This was a use-after-free of monitor, which gets freed by vfs_dir_finalize():

Lines 228 to 233 in e6f2918

    
           if ( dir->monitor ) 
        
           { 
        
               vfs_file_monitor_remove( dir->monitor, 
        
                                        vfs_dir_monitor_callback, 
        
                                        dir ); 
        
           }

I'm not sure why the VFSDir gets destroyed at that point, but it was probably some internal GLib change, as usual.

Fixes #819.

morfikov · 2024-10-13T03:49:54Z

@mati75
I can confirm that the patch works well.

Fix crash when unmounting volumes

82713bb

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Fix crash when unmounting volumes #821

Fix crash when unmounting volumes #821

yut23 commented Sep 28, 2024 •

edited

Loading

morfikov commented Oct 13, 2024 •

edited

Loading

	if ( dir->monitor )
	{
	vfs_file_monitor_remove( dir->monitor,
	vfs_dir_monitor_callback,
	dir );
	}

Fix crash when unmounting volumes #821

Are you sure you want to change the base?

Fix crash when unmounting volumes #821

Conversation

yut23 commented Sep 28, 2024 • edited Loading

morfikov commented Oct 13, 2024 • edited Loading

yut23 commented Sep 28, 2024 •

edited

Loading

morfikov commented Oct 13, 2024 •

edited

Loading