Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider using WeakBoundedVec for CompletedProjects #238

Open
f-gate opened this issue Oct 7, 2023 · 0 comments
Open

Consider using WeakBoundedVec for CompletedProjects #238

f-gate opened this issue Oct 7, 2023 · 0 comments

Comments

@f-gate
Copy link
Member

f-gate commented Oct 7, 2023

Found this nice bit of code in the runtime, since CompletedProjects ofc only gets called when a project is completed its not prone to attack (WHY NOT?). And since reaching the bound on CompletedProjects isnt actually an error this warning should suffice.

if locks.len() as u32 > T::MaxLocks::get() {
	log::warn!(
		target: LOG_TARGET,
		"Warning: A user has more currency locks than expected. \
		A runtime configuration adjustment may be needed."
	);
}
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant