Possible memory leak?

[stefansaravolac]

Hi,

I'm using library(v1.1.1) on node 6.9.1. to retry when saving system errors to database.
For each created error, I create an instance of promise-retry, with options like this:

minTimeout= 6000;
maxTimeout= 10000;
retries= 9999999

When the error is created in the system, it is automatically saved to database.

When I try to run test code with 23 error instances to be created,
the node process breaks due to -heap out of memory-
(on the 8th instance created)

If I turn off library, and just save errors to database without retry,
all 23 errors are saved without memory leak.

I've attached stack excerpt and code I used to simulate memory leak.
It seems to be library bug. Could you please check this?

memoryTest.txt
Stack.txt

[satazor]

I will need a reproducible test/code so that I can debug. Are you able to attach a small zip file and instructions?

[stefansaravolac]

Hi. Please check memoryTest.txt for code, and Stack.txt for error, from previous post.

[lbland]

any update on this?

[satazor]

I didn’t have time to inspect this and without any reproducible test / repo it’s hard. Usually this is a leak in your code not with this module.

[satazor]

Actually @stefansaravolac supplied some test code, will try to debug in the next couple of days..

[huan]

Hello, I'm planing to use this project on my server, so I want to know had this issue been confirmed or fixed?

[tcollinsworth]

Experienced this multiple times and just reproduced and fixed excessive memory/GC in a service using this library.
The underlying retry library uses memory and creates garbage proportionate to the retries value.
Use a much lower value for retries and higher maxTimeout.
OR better yet
Use forever and evaluate the retry count in the loop if it's desired to quit after some number of retries.

[adams-family]

@satazor Were you able to debug it as in your comment above? Memory leak is a problem I think.

[adams-family]

For anyone who is interested, until this is resolved, I've just reverted back to (a slightly modified version of):

function retryForever(fn) {
  return fn().catch(function(err) { 
    return retryForever(fn); 
  });
}

Source: https://stackoverflow.com/questions/30471131/how-can-you-retry-after-an-exception-in-javascript-when-using-promises

[collaorodrigo7]

We are experiencing the same problem described in this issue. We actually were not sure what was causing it until we came across this issue.
We were able to replicate following the code posted by @stefansaravolac