Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Split cardano-shelley-ma into two Allegra and Mary #3171

Open
1 of 2 tasks
lehins opened this issue Nov 28, 2022 · 1 comment
Open
1 of 2 tasks

Split cardano-shelley-ma into two Allegra and Mary #3171

lehins opened this issue Nov 28, 2022 · 1 comment
Assignees
@lehins
Labels
anachronistic adr with hindsight on our side, this is a good ADR 💳 technical-debt Issues related to technical debt we introduced

Comments

@lehins
Copy link
Collaborator

lehins commented Nov 28, 2022 •
edited
Loading

Current implementation of ShelleyMA is unlike all other eras and is quite awkward and sometimes gets into way of implementing new features.

The plan is to:

  • - (done in Split shelley-ma into allegra and mary #3175) Split cardano-ledger-shelley-ma into cardano-ledger-allegra and cardano-ledger-mary
    • Keep cardano-ledger-shelley-ma for a while with some deprecations instructions how to transition to new packages. Breakage should be minimal
    • Get rid of ShelleyMA ma era type and MAClass class as no longer useful
  • - Move cardano-ledger-shelley-ma-test functionality into testlib sublibraries in the cardano-ledger-allegra and cardano-ledger-mary
@lehins lehins self-assigned this Nov 28, 2022
@JaredCorduan JaredCorduan added the 💳 technical-debt Issues related to technical debt we introduced label Nov 29, 2022
This was referenced Nov 30, 2022
Closed
Merged
@JaredCorduan JaredCorduan added the anachronistic adr with hindsight on our side, this is a good ADR label Dec 2, 2022
@lehins
Copy link
Collaborator Author

lehins commented Feb 4, 2025

This is now a subtask of #3623

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@lehins lehins

Labels
anachronistic adr with hindsight on our side, this is a good ADR 💳 technical-debt Issues related to technical debt we introduced
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JaredCorduan @lehins