Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change how we serialize pulser state #4079

Open
lehins opened this issue Feb 13, 2024 · 0 comments
Open

Change how we serialize pulser state #4079

lehins opened this issue Feb 13, 2024 · 0 comments
Assignees

Comments

@lehins
Copy link
Collaborator

lehins commented Feb 13, 2024

Currently we force pulser prior to serializing the result. This has couple of downsides:

  • This sometimes results in a massive computation at an arbitrary point, especially at the beginning of the epoch. By itself it is not a huge deal, since it happens in a separate thread, but it puts pressure on the garbage collector which does affect the running node.
  • That computation is discarded after serialization is done. Which means that same computation will continue being performed by the pulser until the end of the epoch

There are two approaches we can try to alleviate this issue:

  1. Store the initial state and perform the pulser computation upon deserialization.
  2. Store the actual pulser state.

The first approach will affect the startup time of the node, while the second approach will probably be the most complicated, but it has no issues with performance.

I believe we should first try the 1st approach, because it should be easy and see how does it affect the snapshotting profile.

@lehins lehins self-assigned this Oct 28, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant