Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

cmake files management #15

Closed
jamiebresch opened this issue Feb 17, 2021 · 6 comments
Closed

cmake files management #15

jamiebresch opened this issue Feb 17, 2021 · 6 comments

Comments

@jamiebresch
Copy link

jamiebresch commented Feb 17, 2021

PR #8 added a few cmake files from MPAS-Dev/MPAS-Model developed for CIME/E3SM that are not part of ecbuild/cmake implemented in PR #1. That probably does not impact ecbuild/cmake. It is just confusing to see a mix of different cmake implementation.

@jjguerrette
Copy link

Wow, that is confusing. We lucked out that E3SM defined the top-level CMakeLists.txt under src instead of in the base directory as we are using for mpas-bundle. Some common solution will need to be worked out when resolving MPAS-Dev#789.

@jamiebresch
Copy link
Author

MPAS-Dev#767 (to branch ocean/develop) cmake for core_ocean is a concern for mpas-bundle cmake.

@jjguerrette
Copy link

jjguerrette commented Feb 17, 2021

@jamiebresch, not only does that PR add an alternative CMakeLists.txt in the base directory, but it also sets the ocean core as the default. That is VERY problematic. There should not be a default core. The mpas-bundle cmake mechanism enables the core selection through an environment variable. Although, as we know, simultaneous core builds are not working right now.

@climbfuji
Copy link

I am currently looking at a few issues with the MPAS cmake build system. What do we do about this particular issue?

@jjguerrette
Copy link

It is my understanding that the ocean core will be developed in a separate GitHub repo from now on. @mgduda, is that true?

@symoore90
Copy link

Closing due to lack of activity.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants